Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix lint warnings in propagator-jaeger, propagator-b3, resources, and sdk-metrics-base packages #2406

Merged
merged 6 commits into from
Aug 14, 2021

Conversation

alisabzevari
Copy link
Contributor

Which problem is this PR solving?

  • This PR fixes lint warnings in propagator-jaeger, propagator-b3, resources, and sdk-metrics-base packages (related to Fix lint warnings #1093)

Short description of the changes

  • Fix lint warnings

@alisabzevari alisabzevari requested a review from a team August 9, 2021 19:11
@@ -42,7 +42,7 @@ function isValidSampledValue(sampled: TraceFlags | undefined): boolean {
return sampled === TraceFlags.SAMPLED || sampled === TraceFlags.NONE;
}

export function parseHeader(header: unknown) {
function parseHeader(header: unknown) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed export by intuition. Let me know if I did wrong here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass it's probably fine. It might have been exported for those

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #2406 (f5ac849) into main (33e6f71) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2406      +/-   ##
==========================================
- Coverage   92.64%   92.62%   -0.03%     
==========================================
  Files         137      137              
  Lines        4975     4975              
  Branches     1048     1048              
==========================================
- Hits         4609     4608       -1     
- Misses        366      367       +1     
Impacted Files Coverage Δ
...pentelemetry-sdk-metrics-base/src/MeterProvider.ts 88.57% <ø> (ø)
...entelemetry-propagator-b3/src/B3MultiPropagator.ts 100.00% <100.00%> (ø)
...es/opentelemetry-propagator-b3/src/B3Propagator.ts 100.00% <100.00%> (ø)
...ntelemetry-propagator-b3/src/B3SinglePropagator.ts 100.00% <100.00%> (ø)
...elemetry-propagator-jaeger/src/JaegerPropagator.ts 100.00% <100.00%> (ø)
...esources/src/platform/node/default-service-name.ts 100.00% <100.00%> (ø)
...lemetry-sdk-metrics-base/src/BaseObserverMetric.ts 100.00% <100.00%> (ø)
...emetry-sdk-metrics-base/src/BatchObserverResult.ts 100.00% <100.00%> (ø)
...pentelemetry-sdk-metrics-base/src/CounterMetric.ts 100.00% <100.00%> (ø)
...kages/opentelemetry-sdk-metrics-base/src/Metric.ts 90.24% <100.00%> (ø)
... and 4 more

@alisabzevari alisabzevari changed the title Fix lint warnings in propagator-jaeger, propagator-b3, resources, and sdk-metrics-base packages chore: Fix lint warnings in propagator-jaeger, propagator-b3, resources, and sdk-metrics-base packages Aug 10, 2021
@vmarchaud vmarchaud merged commit bdb12da into open-telemetry:main Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants