chore: 0.19.0 release proposal #2107

dyladan · 2021-04-13T16:44:55Z

💥 Breaking Change

opentelemetry-core, opentelemetry-tracing
- #2111 feat: handle OTEL_TRACES_SAMPLER env var (@jtmalinowski)
- #2098 chore(env): update default value for span's attributes/links/events count General environment configuration #1675 (@vmarchaud)
opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-semantic-conventions, opentelemetry-tracing, opentelemetry-web
- #2083 feat: add semconv generator for semantic-conventions-package (@weyert)
opentelemetry-core, opentelemetry-grpc-utils, opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-instrumentation, opentelemetry-node, opentelemetry-plugin-grpc-js, opentelemetry-plugin-grpc, opentelemetry-plugin-http, opentelemetry-plugin-https, opentelemetry-sdk-node, opentelemetry-web
- #2081 remove plugins (@obecny)
opentelemetry-api-metrics, opentelemetry-context-async-hooks, opentelemetry-context-zone-peer-dep, opentelemetry-core, opentelemetry-exporter-collector-grpc, opentelemetry-exporter-collector-proto, opentelemetry-exporter-collector, opentelemetry-exporter-jaeger, opentelemetry-exporter-prometheus, opentelemetry-exporter-zipkin, opentelemetry-grpc-utils, opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-instrumentation, opentelemetry-metrics, opentelemetry-node, opentelemetry-plugin-grpc-js, opentelemetry-plugin-grpc, opentelemetry-plugin-http, opentelemetry-plugin-https, opentelemetry-propagator-b3, opentelemetry-propagator-jaeger, opentelemetry-resource-detector-aws, opentelemetry-resource-detector-gcp, opentelemetry-resources, opentelemetry-sdk-node, opentelemetry-shim-opentracing, opentelemetry-tracing, opentelemetry-web
- #2074 chore: peer depend on API (@dyladan)
- #2063 chore: update API dependency to 1.0.0-rc.0 (@dyladan)
opentelemetry-core, opentelemetry-propagator-b3
- #2054 refactor: simplify b3 options (@mwear)

🚀 (Enhancement)

opentelemetry-instrumentation
- #2135 fix: add isEnabled to InstrumentationBase (@seemk)
opentelemetry-semantic-conventions
- #2115 feat: upgrade semantic conventions to v1.2.0 of spec (@weyert)
opentelemetry-core, opentelemetry-exporter-zipkin
- #2097 feat(zipkin): allow to configure url via environment General environment configuration #1675 (@vmarchaud)
opentelemetry-exporter-zipkin
- #2050 chore: adding interceptor for getting headers before each request (@obecny)
opentelemetry-exporter-collector-grpc
- #2092 Migrate exporter-collector-grpc to grpc-js (@obecny)
opentelemetry-instrumentation-http
- #2043 chore: avoid unneeded context.with in http instrumentation (@Flarna)
opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-xml-http-request
- #2061 chore: adding info to debug whenever headers are being skipped due to cors policy (@obecny)

🐛 (Bug Fix)

opentelemetry-exporter-prometheus
- #2121 fix: ensure the label names are sanitised (@weyert)
opentelemetry-instrumentation
- #2120 fix(instrumentation): support multiple module definitions with different versions (@seemk)
opentelemetry-instrumentation-http, opentelemetry-tracing
- #2105 fix: don't use spanId from invalid parent (@Flarna)
opentelemetry-context-async-hooks
- #2088 fix: correct removeAllListeners in case no event is passed (@Flarna)
opentelemetry-resource-detector-aws
- #2076 fix: await http response in AWS EKS detector (@vreynolds)
opentelemetry-core, opentelemetry-propagator-b3, opentelemetry-propagator-jaeger
- #2082 chore: do not inject span context when instrumentation is suppressed (@dyladan)
opentelemetry-core
- #2080 fix: do not inject invalid span context (@dyladan)
opentelemetry-tracing
- #2086 fix: exception.type should always be a string (@YanivD)
opentelemetry-propagator-jaeger
- #1986 fix(propagator-jaeger): zero pad extracted trace id to 32 characters (@sid-maddy)

📚 (Refine Doc)

#2094 chore: fixing readme info (@obecny)
#2051 Add opentelemetry.io docs (@austinlparker)

🏠 (Internal)

opentelemetry-exporter-collector-grpc, opentelemetry-metrics, opentelemetry-tracing
- #1780 chore: no-floating-promises (@naseemkullah)
opentelemetry-context-zone, opentelemetry-core, opentelemetry-exporter-collector-grpc, opentelemetry-exporter-collector-proto, opentelemetry-exporter-collector, opentelemetry-exporter-jaeger, opentelemetry-exporter-prometheus, opentelemetry-exporter-zipkin, opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-instrumentation, opentelemetry-metrics, opentelemetry-node, opentelemetry-propagator-jaeger, opentelemetry-resource-detector-aws, opentelemetry-resource-detector-gcp, opentelemetry-resources, opentelemetry-sdk-node, opentelemetry-shim-opentracing, opentelemetry-tracing, opentelemetry-web
- #2073 chore: pin own deps (@dyladan)

Committers: 15

Anuraag Agrawal (@anuraaga)
Austin Parker (@austinlparker)
Bartlomiej Obecny (@obecny)
Daniel Dyla (@dyladan)
Gerhard Stöbich (@Flarna)
Jakub Malinowski (@jtmalinowski)
Matthew Wear (@mwear)
Naseem (@naseemkullah)
Niek Kruse (@niekert)
Siddhesh Mhadnak (@sid-maddy)
Siim Kallas (@seemk)
Valentin Marchaud (@vmarchaud)
Vera Reynolds (@vreynolds)
Weyert de Boer (@weyert)
Yaniv Davidi (@YanivD)

codecov · 2021-04-13T16:54:11Z

Codecov Report

Merging #2107 (07a7821) into main (d3989d3) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 07a7821 differs from pull request most recent head 6210cce. Consider uploading reports for the commit 6210cce to get more accurate results

@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
+ Coverage   92.75%   92.77%   +0.02%     
==========================================
  Files         140      140              
  Lines        4981     4981              
  Branches     1028     1028              
==========================================
+ Hits         4620     4621       +1     
+ Misses        361      360       -1

Impacted Files	Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts	`93.75% <0.00%> (+6.25%)`	⬆️

Flarna · 2021-04-13T17:03:06Z

Should we do a API 1.0.0-rc.1 first which includes the breaking change open-telemetry/opentelemetry-js-api#32 first?

packages/opentelemetry-context-zone/package.json

vmarchaud · 2021-04-14T12:01:46Z

Should we do a API 1.0.0-rc.1 first which includes the breaking change open-telemetry/opentelemetry-js-api#32 first?

I would personaly prefer to do a first release without plugins and update this afterwards

dyladan · 2021-04-14T12:07:22Z

We did the same with the API. We released a 0.x version, then immediately released a 1.0.0-rc.0

Flarna · 2021-04-14T12:13:59Z

I'm fine with either way. Not sure anyway if breaking changes between -rc.0 and -rc.1 need to be really consider as breaking - they are dev versions.

dyladan · 2021-04-19T15:17:55Z

@open-telemetry/javascript-approvers @open-telemetry/javascript-maintainers

Flarna

Some points to consider:

Update Compatibility Matrix in Readme
I think we should mention that API is now a peer dependency in upgrade guidelines of readme
Merge master + regenerate changelog

dyladan · 2021-04-19T16:58:39Z

Some points to consider:

Update Compatibility Matrix in Readme

I think we should mention that API is now a peer dependency in upgrade guidelines of readme

Merge master + regenerate changelog

Done thanks

obecny · 2021-04-19T18:58:31Z

Some points to consider:

Update Compatibility Matrix in Readme

I think we should mention that API is now a peer dependency in upgrade guidelines of readme

Merge master + regenerate changelog

Done thanks

I can't see the readme.md changes, was this done in separate PR ?

dyladan · 2021-04-19T19:02:46Z

Forgot to push 👎

obecny · 2021-04-19T19:43:47Z

I think we should mention that API is now a peer dependency in upgrade guidelines of readme

~~Correct me if I'm wrong but shouldn't we have then a peerDependencies section in each package.json that will point to api ?~~

Nevermind I see it was changed earlier

chore: 0.19.0 release proposal

db344f3

dyladan requested review from Flarna, johnbley, legendecas, markwolff, mayurkale22, mwear, naseemkullah, obecny, OlivierAlbertini and vmarchaud as code owners April 13, 2021 16:44

Flarna reviewed Apr 13, 2021

View reviewed changes

packages/opentelemetry-context-zone/package.json Outdated Show resolved Hide resolved

chore: pin our deps

5d92ae4

vmarchaud approved these changes Apr 19, 2021

View reviewed changes

Flarna approved these changes Apr 19, 2021

View reviewed changes

dyladan added 2 commits April 19, 2021 12:55

Merge remote-tracking branch 'origin/main' into 0.19.0-proposal

8d0fc5a

chore: update changelog and readme

9f30a9a

obecny approved these changes Apr 19, 2021

View reviewed changes

dyladan added 2 commits April 20, 2021 16:29

Merge branch 'main' into 0.19.0-proposal

ae94abe

chore: update changelog

6b3ec0d

dyladan added 2 commits April 21, 2021 11:44

Merge remote-tracking branch 'origin/main' into 0.19.0-proposal

2a9603d

chore: update changelog

6210cce

dyladan merged commit 0c15999 into open-telemetry:main Apr 22, 2021

dyladan deleted the 0.19.0-proposal branch April 22, 2021 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: 0.19.0 release proposal #2107

chore: 0.19.0 release proposal #2107

dyladan commented Apr 13, 2021 •

edited

Loading

codecov bot commented Apr 13, 2021 •

edited

Loading

Flarna commented Apr 13, 2021

vmarchaud commented Apr 14, 2021

dyladan commented Apr 14, 2021

Flarna commented Apr 14, 2021

dyladan commented Apr 19, 2021

Flarna left a comment

dyladan commented Apr 19, 2021

obecny commented Apr 19, 2021

dyladan commented Apr 19, 2021

obecny commented Apr 19, 2021 •

edited

Loading

chore: 0.19.0 release proposal #2107

chore: 0.19.0 release proposal #2107

Conversation

dyladan commented Apr 13, 2021 • edited Loading

💥 Breaking Change

🚀 (Enhancement)

🐛 (Bug Fix)

📚 (Refine Doc)

🏠 (Internal)

Committers: 15

codecov bot commented Apr 13, 2021 • edited Loading

Codecov Report

Flarna commented Apr 13, 2021

vmarchaud commented Apr 14, 2021

dyladan commented Apr 14, 2021

Flarna commented Apr 14, 2021

dyladan commented Apr 19, 2021

Flarna left a comment

Choose a reason for hiding this comment

dyladan commented Apr 19, 2021

obecny commented Apr 19, 2021

dyladan commented Apr 19, 2021

obecny commented Apr 19, 2021 • edited Loading

dyladan commented Apr 13, 2021 •

edited

Loading

codecov bot commented Apr 13, 2021 •

edited

Loading

obecny commented Apr 19, 2021 •

edited

Loading