-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: avoid unneeded context.with in http instrumentation #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the overhead of context.with() by directly passing the extracted context to tracer.startSpan(). This ensures also that the extracted context is not accidently propagated out of the HTTP instrumentation.
Flarna
requested review from
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
March 24, 2021 22:03
Codecov Report
@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
- Coverage 92.76% 92.74% -0.03%
==========================================
Files 137 137
Lines 4904 4904
Branches 1012 1013 +1
==========================================
- Hits 4549 4548 -1
- Misses 355 356 +1
|
dyladan
approved these changes
Apr 7, 2021
vmarchaud
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the overhead of
context.with()
by directly passing the extracted context totracer.startSpan()
.This ensures also that the extracted context is not accidentally propagated out of the HTTP instrumentation.