-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exception.type should always be a string #2086
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2086 +/- ##
==========================================
- Coverage 93.05% 93.03% -0.02%
==========================================
Files 154 154
Lines 5976 5976
Branches 1246 1246
==========================================
- Hits 5561 5560 -1
- Misses 415 416 +1
|
Could you add a quick test that verify that the result is always a string ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the test !
Which problem is this PR solving?
By Semantic Conventions for Exceptions -
exception.type
should be a string.Short description of the changes
Cast to string for numeric exception codes.