Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracer interface #125

Merged

Conversation

OlivierAlbertini
Copy link
Member

@OlivierAlbertini OlivierAlbertini commented Jul 23, 2019

Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Change return type "unknow" to BinaryFormat for getBinaryFormat

Close #124
Close #123

Signed-off-by: Olivier Albertini [email protected]

@codecov-io
Copy link

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files          27       27           
  Lines        1784     1784           
  Branches      201      201           
=======================================
  Hits         1764     1764           
  Misses         20       20

@OlivierAlbertini OlivierAlbertini force-pushed the feature/httptextformat branch from 03d6968 to 006f4d5 Compare July 23, 2019 20:28
Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Change return type "unknow" to BinaryFormat for getBinaryFormat
Close open-telemetry#124 open-telemetry#123

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini force-pushed the feature/httptextformat branch from 006f4d5 to 42f3809 Compare July 23, 2019 20:44
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22 mayurkale22 merged commit c225d84 into open-telemetry:master Jul 24, 2019
@mayurkale22 mayurkale22 mentioned this pull request Jul 24, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…ess-4.x

chore(deps): update dependency @types/express to v4.17.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracer API: Replace unknown type with HttpTextFormat Tracer API: Replace unknown type with BinaryFormat
4 participants