Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracer API: Replace unknown type with HttpTextFormat #124

Closed
mayurkale22 opened this issue Jul 23, 2019 · 0 comments · Fixed by #125
Closed

Tracer API: Replace unknown type with HttpTextFormat #124

mayurkale22 opened this issue Jul 23, 2019 · 0 comments · Fixed by #125
Labels
enhancement New feature or request
Milestone
API complete

Comments

@mayurkale22
Copy link
Member

opentelemetry-js/packages/opentelemetry-types/src/trace/tracer.ts

Lines 89 to 91 in 39ca469

* @todo: Change return type once HttpTextFormat is available
*/
getHttpTextFormat(): unknown;

@mayurkale22 mayurkale22 added the enhancement New feature or request label Jul 23, 2019
@mayurkale22 mayurkale22 added this to the API complete milestone Jul 23, 2019
@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jul 23, 2019
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Jul 23, 2019
@OlivierAlbertini
Update tracer interface
03d6968 
Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Close open-telemetry#124

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini mentioned this issue Jul 23, 2019
Merged
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Jul 23, 2019
@OlivierAlbertini
Update tracer interface
006f4d5 
Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Change return type "unknow" to BinaryFormat for getBinaryFormat
Close open-telemetry#124 open-telemetry#123

Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Jul 23, 2019
@OlivierAlbertini
Update tracer interface
42f3809 
Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Change return type "unknow" to BinaryFormat for getBinaryFormat
Close open-telemetry#124 open-telemetry#123

Signed-off-by: Olivier Albertini <[email protected]>
mayurkale22 pushed a commit that referenced this issue Jul 24, 2019
@OlivierAlbertini @mayurkale22
Update tracer interface (#125)
c225d84 
Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Change return type "unknow" to BinaryFormat for getBinaryFormat
Close #124 #123

Signed-off-by: Olivier Albertini <[email protected]>
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jul 24, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@mayurkale22
Merge pull request open-telemetry#124 from renovate-bot/renovate/node…
8deb3cd 
…-13.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
API complete
Development

Successfully merging a pull request may close this issue.

Update tracer interface OlivierAlbertini/opentelemetry-js
1 participant
@mayurkale22