Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracer interface #125

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Update tracer interface #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/opentelemetry-types/src/trace/tracer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@
* limitations under the License.
*/

import { HttpTextFormat } from '../context/propagation/HttpTextFormat';
import { Span } from './span';
import { SpanOptions } from './SpanOptions';
import { BinaryFormat } from '../context/propagation/BinaryFormat';

/**
* Tracer provides an interface for creating {@link Span}s and propagating
Expand Down Expand Up @@ -73,10 +75,8 @@ export interface Tracer {
* Context binary format ({@link BinaryFormat}). For more details see
* <a href="https://w3c.github.io/trace-context-binary/">W3C Trace Context
* binary protocol</a>.
*
* @todo: Change return type once BinaryFormat is available
*/
getBinaryFormat(): unknown;
getBinaryFormat(): BinaryFormat;

/**
* Returns the {@link HttpTextFormat} interface which can inject/extract
Expand All @@ -85,8 +85,6 @@ export interface Tracer {
* If no tracer implementation is provided, this defaults to the W3C Trace
* Context HTTP text format ({@link HttpTraceContext}). For more details see
* <a href="https://w3c.github.io/trace-context/">W3C Trace Context</a>.
*
* @todo: Change return type once HttpTextFormat is available
*/
getHttpTextFormat(): unknown;
getHttpTextFormat(): HttpTextFormat;
}