Don't create duplicate headers #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
...mmon/src/main/groovy/io/opentelemetry/instrumentation/test/server/http/TestHttpServer.groovy
Outdated
Show resolved
Hide resolved
testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpClientTest.groovy
Show resolved
Hide resolved
anuraaga
reviewed
Apr 9, 2021
...umentation/akka-http-10.0/javaagent/src/test/groovy/AkkaHttpClientInstrumentationTest.groovy
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Apr 12, 2021
instrumentation/http-url-connection/javaagent/src/test/groovy/SpringRestTemplateTest.groovy
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2594
Adds a new test to
HttpClientTestthat create a request, sends the request, and then reuses that request (sending it a second time).Most of the http client libraries support this kind of reuse, and several of our instrumentations would end up adding the
traceparentheader multiple times (#2594).HttpTestServernow throws an exception if there is more than onetraceparentheader.To implement the new test, the
doRequest()method that was implemented in each subclass ofHttpClientTesthas been split into two methods:buildRequest()sendRequest()The normal
doRequest(now final) is implemented asbuildRequest+sendRequest, while the newdoReusedRequest(also final) is implemented asbuildRequest+sendRequest+sendRequest.