Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpHeadersInjectAdapter should use 'setHeader' instead of 'addHeader'? #2594

Closed
lshangq opened this issue Mar 18, 2021 · 1 comment · Fixed by #2727
Closed

HttpHeadersInjectAdapter should use 'setHeader' instead of 'addHeader'? #2594

lshangq opened this issue Mar 18, 2021 · 1 comment · Fixed by #2727
Labels
bug Something isn't working

Comments

@lshangq
Copy link

lshangq commented Mar 18, 2021

Describe the bug
If reuse http request, traceparent header will be more and more when use apache-httpclient4.x and 5.x

image

What version are you using?
v1.0.1

Add any other context about the problem here.

@lshangq lshangq added the bug Something isn't working label Mar 18, 2021
@iNikem
Copy link
Contributor

iNikem commented Mar 18, 2021

@lshangq Can you please provide a demo or reproducible test case? It generally should be a bug in our instrumentation if we try to inject span context into an outgoing request more that once. But your case seems to differ. Would like to understand it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants