Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix grpc set metadata multi-value #11308

Merged
merged 6 commits into from
Jun 4, 2024
Merged

fix grpc set metadata multi-value #11308

merged 6 commits into from
Jun 4, 2024

Conversation

wgy035
Copy link
Contributor

@wgy035 wgy035 commented May 8, 2024

Resolves #11237
removeAll key before put in grpc MetadataSetter

@wgy035 wgy035 requested a review from a team May 8, 2024 13:00
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 8, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@steverao
Copy link
Contributor

steverao commented May 9, 2024

@wgy035 Please sign the CLA.

@trask
Copy link
Member

trask commented May 9, 2024

@wgy035 can you add a test for this? (check out #2727 for possible inspiration)

@laurit laurit mentioned this pull request May 17, 2024
Closed
@wgy035
Copy link
Contributor Author

wgy035 commented May 21, 2024

Got it. And now I'm trying to add a test.

@laurit
Copy link
Contributor

laurit commented May 29, 2024

@wgy035 I have crated a PR for your PR wgy035#1 that changes the test so that it uses a standard propagator and verifies that injecting the tracing context twice results in the last inject overwriting the first one.

@wgy035
Merge pull request #1 from laurit/grpc-overwrite-metadata
8c2042c 
Improve grpc metadata overwrite test
@trask trask merged commit a47c406 into open-telemetry:main Jun 4, 2024
53 checks passed
@wgy035 wgy035 deleted the grpc-fix-metadata branch June 5, 2024 02:17
zeitlinger pushed a commit to zeitlinger/opentelemetry-java-instrumentation that referenced this pull request Jun 12, 2024
@wgy035 @laurit @zeitlinger
fix grpc set metadata multi-value (open-telemetry#11308)
8b7723e 
Co-authored-by: Lauri Tulmin <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@wgy035 @laurit @opentelemetrybot
fix grpc set metadata multi-value (#11308)
b7fb1ab 
Co-authored-by: Lauri Tulmin <[email protected]>
@opentelemetrybot opentelemetrybot mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverao steverao steverao left review comments

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In io.opentelemetry.instrumentation.grpc.v1_6 the Setter duplicates instead of replacing
4 participants
@wgy035 @steverao @trask @laurit