-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LastValue by default for ValueObserver instruments #1165
Merged
Aneurysm9
merged 21 commits into
open-telemetry:master
from
jmacd:jmacd/lastvalue_observer
Sep 24, 2020
Merged
Use LastValue by default for ValueObserver instruments #1165
Aneurysm9
merged 21 commits into
open-telemetry:master
from
jmacd:jmacd/lastvalue_observer
Sep 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
evantorrie,
lizthegrey,
MrAlias and
XSAM
as code owners
September 12, 2020 06:40
evantorrie
reviewed
Sep 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
========================================
+ Coverage 76.4% 76.5% +0.1%
========================================
Files 134 134
Lines 5732 5751 +19
========================================
+ Hits 4384 4405 +21
+ Misses 1105 1103 -2
Partials 243 243
|
This corresponds with open-telemetry/opentelemetry-specification#984. |
MrAlias
reviewed
Sep 22, 2020
Aneurysm9
approved these changes
Sep 23, 2020
MrAlias
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification will state that ValueObserver uses LastValue aggregation by default. This includes adding OTLP Exporter support for LastValue aggregation.
Resolves #1139.
Part of #1177.
Corresponds with open-telemetry/opentelemetry-specification#984.