Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Metrics to OTLP v0.5 #1177

Closed
jmacd opened this issue Sep 14, 2020 · 3 comments
Closed

Upgrade Metrics to OTLP v0.5 #1177

jmacd opened this issue Sep 14, 2020 · 3 comments
Labels
area:metrics Part of OpenTelemetry Metrics duplicate This issue or pull request already exists
Milestone
untracked

Comments

@jmacd
Copy link
Contributor

jmacd commented Sep 14, 2020

The OTLP exporter in this repository is still at version 0.3. To bring it forward to v0.5 will require two new supports to be in place.

  1. LastValue aggregation is required: being added in Use LastValue by default for ValueObserver instruments #1165.
  2. Histogram aggregation is required: no open PR

Histogram aggregation is required as an alternative to Summary data points. Since Summary has no current expression in OTLP v0.5, and at the specification level we are leaning in the direction of Histogram or Histogram-like-Sketch as the default aggregation for ValueRecorder instruments, moving this repository to v0.5 with Histogram implemented for ValueRecorder is the closest we can get to the specification.

After LastValue and Histogram support are added at the current protocol version, the exporter can be upgraded to v0.5.
@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Sep 14, 2020
@jmacd jmacd changed the title Upgrade to OTLP v0.5 Upgrade Metrics to OTLP v0.5 Sep 14, 2020
@jmacd jmacd mentioned this issue Sep 14, 2020
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Sep 15, 2020

Is this a duplicate of #1123?

@jmacd
Copy link
Contributor Author

jmacd commented Sep 15, 2020

Yes, except I've put in more detail about how I think it should be sequenced.

@MrAlias
Copy link
Contributor

MrAlias commented Oct 1, 2020

I've updated the description of #1123 to include the information included here and going to close this to resolve the duplicity.

@MrAlias MrAlias closed this as completed Oct 1, 2020
@MrAlias MrAlias added the duplicate This issue or pull request already exists label Oct 1, 2020
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics duplicate This issue or pull request already exists
Projects
None yet
Milestone
untracked
Development

No branches or pull requests
3 participants
@jmacd @pellared @MrAlias