Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OTLP to v0.5.0 #1123

Closed
2 tasks done
MrAlias opened this issue Sep 3, 2020 · 6 comments · Fixed by #1230
Closed
2 tasks done

Upgrade OTLP to v0.5.0 #1123

MrAlias opened this issue Sep 3, 2020 · 6 comments · Fixed by #1230
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 3, 2020

The OTLP exporter in this repository is still at version v0.3.0 of the OTLP and needs to be upgraded to the latest version (currently v0.5.0). This will require:

  1. LastValue aggregation is required: being added in Use LastValue by default for ValueObserver instruments #1165.
  2. Histogram aggregation is required: no open PR

Histogram aggregation is required as an alternative to Summary data points. Since Summary has no current expression in OTLP v0.5, and at the specification level we are leaning in the direction of Histogram or Histogram-like-Sketch as the default aggregation for ValueRecorder instruments, moving this repository to v0.5 with Histogram implemented for ValueRecorder is the closest we can get to the specification.

After LastValue and Histogram support are added at the current protocol version, the exporter can be upgraded to v0.5.

@MrAlias MrAlias added this to the RC1 milestone Sep 3, 2020
@MrAlias MrAlias added the help wanted Extra attention is needed label Oct 1, 2020
@jmacd
Copy link
Contributor

jmacd commented Oct 6, 2020

We have histogram aggregation now, so the next step is just to upgrade the protocol, where all we do is swap protocol versions. This will require changing the default for ValueRecorder to Histogram, which is now implemented for OTLP.

@codeboten
Copy link
Contributor

I'm happy to help with this one

@codeboten
Copy link
Contributor

What's the expected OTLP datapoints for MinMaxSumCountKind aggregation now that SummaryDataPoint is gone? @jmacd @MrAlias

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 8, 2020

What's the expected OTLP datapoints for MinMaxSumCountKind aggregation now that SummaryDataPoint is gone?

Hmm, I don't know off-hand. I thought it was something the metric SIG is still discussing the best way to add this into the proto IIRC.

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 8, 2020

This seems reasonable for now. @codeboten out of curiosity, did this come from the collectors interpretation of these?

@codeboten
Copy link
Contributor

This seems reasonable for now. @codeboten out of curiosity, did this come from the collectors interpretation of these?

I ended up following the java implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants