Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Jaeger remote sampler #327

Closed
almariah opened this issue Nov 16, 2019 · 7 comments · Fixed by open-telemetry/opentelemetry-go-contrib#936
Closed

Support for Jaeger remote sampler #327

almariah opened this issue Nov 16, 2019 · 7 comments · Fixed by open-telemetry/opentelemetry-go-contrib#936
Labels
area:trace Part of OpenTelemetry tracing pkg:exporter:jaeger Related to the Jaeger exporter package
Milestone

Comments

@almariah
Copy link
Contributor

The remote sampler will consult Jaeger agent for the appropriate sampling strategy to use. This allows controlling the sampling strategies in the services from a central configuration in Jaeger backend, or even dynamically.

@jmacd
Copy link
Contributor

jmacd commented Nov 21, 2019

@lizthegrey Do you have thoughts on this, given your OTEP about sampling?

@joe-elliott
Copy link

joe-elliott commented Nov 21, 2019

Since this is just a proxy in Jaeger does it make sense to configure and handle this entirely in the receiver?

If we can agree on how to handle this I would be glad to add the feature as we need it internally to start using the otel collector.

@bogdandrutu
Copy link
Member

We discussed about the collector integration to use extensions.

@annanay25
Copy link

annanay25 commented Nov 22, 2019

I will pick this up.

@bogdandrutu - should this issue be moved to otel-col repo?

@rghetia
Copy link
Contributor

rghetia commented Dec 5, 2019

move to collector repo

@jmacd
Copy link
Contributor

jmacd commented Dec 5, 2019

I suspect there is a desire to apply sampling in the client-side SDK, in which case this issue belongs here.

@annanay25
Copy link

Yes, once jaeger remote sampling is implemented in the agent/collector, we can pick up the client side SDK sampling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:exporter:jaeger Related to the Jaeger exporter package
Projects
None yet
8 participants