Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sampler: Jaeger remote #2148

Closed
yvrhdn opened this issue Jul 30, 2021 · 4 comments · Fixed by open-telemetry/opentelemetry-go-contrib#936
Closed

New sampler: Jaeger remote #2148

yvrhdn opened this issue Jul 30, 2021 · 4 comments · Fixed by open-telemetry/opentelemetry-go-contrib#936
Labels
enhancement New feature or request
Milestone

Comments

@yvrhdn
Copy link
Contributor

yvrhdn commented Jul 30, 2021

Problem Statement

We are migrating from OpenTracing to OpenTelemetry, we use the Jaeger exporter and our apps will their sampling strategies from the OTel Collector.
While jaeger_remote is a known value for OTEL_TRACES_SAMPLER according to the specification, this isn't supported yet by opentelemetry-go.

Is there any work in progress to implement this? Is this something you would accept at this point?

Proposed Solution

Add a new implement of the Sampler interface that uses the Jaeger remote protocol to apply sampling strategies.

Alternatives

I'm not aware of any other remote sampling implementations.

Prior Art

I don't know if any other client library has implemented the Jaeger remote sampler.
The Jaeger receiver in collector has support for remote sampling: https://github.com/open-telemetry/opentelemetry-collector/blob/main/receiver/jaegerreceiver/README.md#remote-sampling

Additional Context

N/A

@yvrhdn yvrhdn added the enhancement New feature or request label Jul 30, 2021
@Aneurysm9
Copy link
Member

I'm not aware of any ongoing work on a remote sampler and I don't think there is any reason why we would not accept one if it were provided.

@yvrhdn
Copy link
Contributor Author

yvrhdn commented Aug 1, 2021

I've pushed my work in progress here: #2150, if anyone already wants to take a look. I still have a bunch of TODO's to fix and we'll need two new samplers to support all Jaeger strategies (rate limiting and per operation).

@MrAlias
Copy link
Contributor

MrAlias commented Aug 3, 2021

Related to #327

@MadVikingGod
Copy link
Contributor

The conversation continues in the contrib repo: Add Jaeger remote sampler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants