Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote sampling support instruments #1479

Closed

Conversation

Petrovich172
Copy link

Added sdk/trace/sampling package which contains remote sampling support instruments. Such as:

  • RemotelyControlledSampler — sdk/trace.Sampler implementation. Manages default sampler & perOperation samplers. Fetches sampling strategy from strategy endpoint, and updates samplers.
  • ProbabilisticSampler — sdk/trace/sampling.Sampler implementation.
  • RateLimitingSampler — sdk/trace/sampling.Sampler implementation.

Package is mostly based on jaeger's implementation.
Consider to close this issue

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 20, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #1479 (6060c07) into master (c066f15) will decrease coverage by 1.3%.
The diff coverage is 13.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1479     +/-   ##
========================================
- Coverage    79.0%   77.7%   -1.4%     
========================================
  Files         128     132      +4     
  Lines        6685    6820    +135     
========================================
+ Hits         5282    5300     +18     
- Misses       1148    1265    +117     
  Partials      255     255             
Impacted Files Coverage Δ
sdk/trace/sampling/config.go 0.0% <0.0%> (ø)
sdk/trace/sampling/sampler_remote.go 0.0% <0.0%> (ø)
sdk/trace/sampling/sampler_probabilistic.go 100.0% <100.0%> (ø)
sdk/trace/sampling/sampler_rate_limiting.go 100.0% <100.0%> (ø)

@Petrovich172 Petrovich172 marked this pull request as ready for review January 27, 2021 20:10
Base automatically changed from master to main January 29, 2021 19:39
@MrAlias
Copy link
Contributor

MrAlias commented Mar 4, 2021

Thanks for the idea and contribution. I'm going to close as this is something we would probably want to discuss the need, design, and implementation of in a Issue prior to stating this. There are many design questions here that likely need to be answered at the specification level before we can provide an implementation.

@MrAlias MrAlias closed this Mar 4, 2021
@sconover
Copy link

sconover commented Apr 9, 2021

@MrAlias I look forward to what the otel project produces on this front - what's your expected timeframe for a design to be decided on and an impl to ship?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Jaeger remote sampler
3 participants