Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project does not vendor-in thrift generated files from Jaeger repo #434

Closed
annanay25 opened this issue Jan 17, 2020 · 3 comments
Closed
Labels
help wanted Extra attention is needed pkg:exporter:jaeger Related to the Jaeger exporter package
Milestone

Comments

@annanay25
Copy link

annanay25 commented Jan 17, 2020

I was looking to start work on #327, but quickly realised that the project does not vendor-in the entire thrift-compiled directory from the Jaeger project (https://github.com/open-telemetry/opentelemetry-go/blob/master/exporters/trace/jaeger/internal/gen-go/jaeger/jaeger.go).

All APIs related to span processing have been copied over, but remote sampling definitions are missing. It would be cleaner to vendor in the entire directory as we do as part of the collector project.

@rghetia
Copy link
Contributor

rghetia commented Jan 23, 2020

@annanay25 can you please elaborate on the problem? may be output of failure?

@annanay25
Copy link
Author

@rghetia - what I meant, is that the jaeger.go file in this repo is a duplicate of the thrift-generated files in the jaeger repo. It includes the agent and collector APIs, but the sampling APIs are missing.

We should ideally vendor-in the entire thrift-gen package from jaeger repo.

@MrAlias MrAlias added help wanted Extra attention is needed pkg:exporter labels Sep 30, 2020
@MrAlias MrAlias added pkg:exporter:jaeger Related to the Jaeger exporter package and removed pkg:exporter labels Apr 6, 2021
@MrAlias
Copy link
Contributor

MrAlias commented Apr 6, 2021

This looks like it might have been resolved in #1712

Please reopen if not.

@MrAlias MrAlias closed this as completed Apr 6, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed pkg:exporter:jaeger Related to the Jaeger exporter package
Projects
None yet
Development

No branches or pull requests

4 participants