You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All APIs related to span processing have been copied over, but remote sampling definitions are missing. It would be cleaner to vendor in the entire directory as we do as part of the collector project.
The text was updated successfully, but these errors were encountered:
@rghetia - what I meant, is that the jaeger.go file in this repo is a duplicate of the thrift-generated files in the jaeger repo. It includes the agent and collector APIs, but the sampling APIs are missing.
We should ideally vendor-in the entire thrift-gen package from jaeger repo.
I was looking to start work on #327, but quickly realised that the project does not vendor-in the entire thrift-compiled directory from the Jaeger project (https://github.com/open-telemetry/opentelemetry-go/blob/master/exporters/trace/jaeger/internal/gen-go/jaeger/jaeger.go).
All APIs related to span processing have been copied over, but remote sampling definitions are missing. It would be cleaner to vendor in the entire directory as we do as part of the collector project.
The text was updated successfully, but these errors were encountered: