-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpClient & HttpWebRequest] Set http.request.method
as per spec
#5003
Merged
utpilla
merged 11 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/fix-http-request-method-httpclient
Nov 1, 2023
Merged
[HttpClient & HttpWebRequest] Set http.request.method
as per spec
#5003
utpilla
merged 11 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/fix-http-request-method-httpclient
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5003 +/- ##
==========================================
+ Coverage 83.43% 83.67% +0.24%
==========================================
Files 296 296
Lines 12380 12377 -3
==========================================
+ Hits 10329 10357 +28
+ Misses 2051 2020 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
TimothyMothra
approved these changes
Oct 31, 2023
CodeBlanch
reviewed
Oct 31, 2023
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback about the helper API being confusing but LGTM
utpilla
reviewed
Oct 31, 2023
utpilla
approved these changes
Oct 31, 2023
utpilla
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4994
Design discussion issue #
Changes
Fixes
http.request.method
attribute value on activity and metric as per spec. For details, see the linked issueMerge requirement checklist
CHANGELOG.md
files updated for non-trivial changes