Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.request.method attribute value in HttpClient and ASP.NET Core #4994

Closed
vishweshbankwar opened this issue Oct 26, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@vishweshbankwar
Copy link
Member

vishweshbankwar commented Oct 26, 2023

Bug Report

http.request.method attribute value is set as it is from the original method with which the request was sent/received. This is incorrect. Specification only allows known verbs to be set as http.request.method . Any unknown method MUST be set as _OTHER.

Spec reference

When the method does not match one of the known verbs then http.request.method_original should be set on spans only.

Support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS will not be added in initial release to keep the experience consistent between NET8.0 and lower versions. .NET8.0 metrics does not provide this extensibility.

@vishweshbankwar
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant