Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default set of attributes for HttpClient instrumentation (trace and metric) #4993

Closed
vishweshbankwar opened this issue Oct 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@vishweshbankwar
Copy link
Member

vishweshbankwar commented Oct 26, 2023

The issue is to document the default set of attributes that will be part of initial stable release of trace and metric instrumentation library for HttpClient.

Traces

Following is the list of attributes are currently added by default:

Following attributes will not be added by default and Enrich API can be used in case if these attributes are needed:

  • network.peer.address
  • network.peer.port
  • http.request.resend_count

Metrics

For metrics(http.client.request.duration) all the required/recommended attributes will be added by default as per spec

@vishweshbankwar vishweshbankwar added the enhancement New feature or request label Oct 26, 2023
@vishweshbankwar vishweshbankwar changed the title Default set of span attributes for HttpClient instrumentation Default set of span attributes for HttpClient instrumentation (trace and metric) Oct 30, 2023
@vishweshbankwar vishweshbankwar changed the title Default set of span attributes for HttpClient instrumentation (trace and metric) Default set of attributes for HttpClient instrumentation (trace and metric) Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant