Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger pack and publish when release is created #3638

Merged

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Sep 7, 2022

I think I like this approach better than #3634.

The pack and publish job is kicked off automatically upon creating a release in GitHub.

Step 1 - Create and push the tags just as before. Then click create release here:

Screen Shot 2022-09-07 at 4 10 50 PM

Step 2 - Fill out the details of the release as usual:

Screen Shot 2022-09-07 at 4 12 34 PM

Step 3 - Click "Publish release" and the job is kicked off like so:

Screen Shot 2022-09-07 at 4 13 25 PM

@alanwest alanwest requested a review from a team September 7, 2022 23:33
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #3638 (7fa0c94) into main (d10f1f9) will decrease coverage by 0.22%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   87.80%   87.58%   -0.23%     
==========================================
  Files         283      283              
  Lines       10308    10308              
==========================================
- Hits         9051     9028      -23     
- Misses       1257     1280      +23     
Impacted Files Coverage Δ
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-42.86%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-40.91%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 75.00% <0.00%> (-10.00%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 91.75% <0.00%> (-3.30%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (+2.94%) ⬆️
...Propagators/OpenTelemetryPropagatorsEventSource.cs 100.00% <0.00%> (+12.50%) ⬆️

@TimothyMothra
Copy link
Contributor

This looks like the better option to me.
Triggering the release from the Tag seems straight forward and less error prone.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 16, 2022
@alanwest alanwest removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 19, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 27, 2022
@utpilla utpilla removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 27, 2022
@utpilla utpilla merged commit 4938c35 into open-telemetry:main Sep 28, 2022
@alanwest alanwest deleted the alanwest/trigger-publish-on-release branch September 30, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants