Make publish workflow work based on tag/branch selected #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwest
commented
Sep 7, 2022
alanwest
commented
Sep 7, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3634 +/- ##
==========================================
- Coverage 87.35% 87.34% -0.01%
==========================================
Files 282 282
Lines 10132 10132
==========================================
- Hits 8851 8850 -1
- Misses 1281 1282 +1
|
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
alanwest
removed
the
Stale
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
utpilla
removed
the
Stale
|
Closing this in favor of #3638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
refparameter to the workflow that must be specified when running it. When running the workflow manually, specifying therefis required. For our releases, we create both a "core" and "non-core" tag at the same SHA, and it doesn't matter which of the two tags you run the workflow with.Looks like this:
The nightly build will continue to use
main.There is an alternative we could explore. The pack and publish workflow could be triggered when we draft a new release. If triggered this way, then the workflow would use the SHA of the release. No need to manually run the workflow and type in the tag name.