Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger pack and publish when release is created #3638

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions .github/workflows/publish-packages-1.0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,23 @@
################### IMPORTANT ###################
#################################################

name: Pack and publish to Myget
name: Pack and publish to MyGet

on:
workflow_dispatch:
inputs:
logLevel:
description: 'Log level'
required: true
default: 'warning'
release:
types: [published]
schedule:
- cron: '0 0 * * *' # once in a day at 00:00

jobs:
build-pack:
runs-on: ${{ matrix.os }}

strategy:
matrix:
os: [windows-latest]
branches: [main]
runs-on: windows-latest

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0 # fetching all
ref: ${{ matrix.branches }}
ref: ${{ github.ref || 'main' }}

- uses: actions/setup-dotnet@v2
with:
Expand All @@ -49,7 +40,7 @@ jobs:
- name: Publish Artifacts
uses: actions/upload-artifact@v3
with:
name: ${{ matrix.os }}-packages
name: ${{ github.ref || 'main' }}-packages
path: '**/bin/**/*.*nupkg'

- name: Publish MyGet
Expand Down
26 changes: 12 additions & 14 deletions build/RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,16 @@ Only for Maintainers.

If releasing both, push both tags above.

7. Open [Pack and publish to MyGet
workflow](https://github.com/open-telemetry/opentelemetry-dotnet/actions/workflows/publish-packages-1.0.yml)
and manually trigger a build after selecting the tag that was pushed in Step
6 (if you pushed both core and non-core tags, use any one of them). At the
end of the workflow run, the packages would be published to MyGet. The
package names will be suffixed with the tag names used in Step 1.
7. Go to the [list of
tags](https://github.com/open-telemetry/opentelemetry-dotnet/tags)
and find the tag created for the core components. Click the three
dots next to the tag and choose `Create release`.
* Give the release a name based on the tags created
(e.g., `1.4.0-beta.1 / 1.0.0-rc9.7`).
cijothomas marked this conversation as resolved.
Show resolved Hide resolved
* Paste the contents of combined changelog from Step 2.
* Check "This is a pre-release" if applicable.
* Click "Publish release". This will kick off the [Pack and publish to
MyGet workflow](https://github.com/open-telemetry/opentelemetry-dotnet/actions/workflows/publish-packages-1.0.yml).

8. Validate using MyGet packages. Basic sanity checks :)

Expand Down Expand Up @@ -119,15 +123,9 @@ Only for Maintainers.

15. Delete the API key generated in Step 11.

16. Make the Github release with tag from Step 5 and contents of
combinedchangelog from Step 2.

TODO: Add tagging for Metrics release. TODO: Separate version for
instrumention/hosting/OTshim package.

17. Update the OpenTelemetry.io document
16. Update the OpenTelemetry.io document
[here](https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/net)
by sending a Pull Request.

18. If a new stable version of the core packages were released, update
17. If a new stable version of the core packages were released, update
`OTelPreviousStableVer` in Common.props to the just released stable version.