Update sanity check to cover .github and .vscode folders #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
approved these changes
Aug 5, 2022
alanwest
approved these changes
Aug 5, 2022
Comment on lines
-52
to
-53
| # ℹ️ Command-line programs to run using the OS shell. | ||
| # 📚 https://git.io/JvXDl |
There was a problem hiding this comment.
but but... I like emojis. Can we have sanitycheck require minimum one emoji per file?
There was a problem hiding this comment.
Is there an emoji for OpenTelemetry (maybe 🔭📺📊📈📉)? Might be a good thing (although it's not friendly to developers who use Notepad.exe or vi via telnet) 😃
There was a problem hiding this comment.
(although it's not friendly to developers who use Notepad.exe or vi via telnet)
I have a solution:
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWX0KNWMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWX0OkkOKNWMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWX0OkkkkkkOKNWMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMNKOkkkkkkkkkkOKNWMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMN0kkkkkkkkkkkkkOKNWMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWNKOkkkkkkkkkkkkkOKNWMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWNKOkkkkkkkkkkkkkOKNWMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXOkOXWMWNKOkkkkkkkkkkkkkOKNWMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXkl:;:cxKWMWNKOkkkkkkkkkkkkkOKNWMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWWXkl:;;:;;:lxKWMWNKOkkkkkkkkkkkkkOKNWM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXkdl:;:;;;;;;;:cxKWMWNKOkkkkkkkkkkkkkOXW
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXkl:;;;;:;;;;;;;;::cxKWMWNKOkkkkkkkkkkkOKW
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXkl:::;;;;::;;;:;;:;;;:cxKWMWNKOkkkkkkkO0XWM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMKo:;;;;:;;:;;;;;;;;;::;;;:cxKWMWNKOkkkO0XWMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMKo:;;;;;;;;;;;;;;;;:;;:;;:;:ckNMMWNKKKXWMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMNOl:;;::;;;;;;;;;;;;;;;;;;;:dXMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMNOo:::;;::ccllcc:;:;;:;:lkXWMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMWKkdx0NMMXOxooxO0XXNNXK0kdl::lkXWMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMW0dc:;;:d0NMMWWWWMMWWWWWMMMWXOOXWMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMW0dc;::;;;:cOWMMMMWXK00OO0KXNWMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMW0dc:;;;;;;;:oKMMMWX0kkkOOOOkkOKNMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMW0dc:;;;;;;;;;l0WMWNKOkk0XNWNNKOkk0NMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMW0dc;;;;;;;;;;;;oXMMNK0kk0NMMMMMWKkkOKWMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMW0dc;;;;;:;;;;;;;;oXMMNX0kk0NMMMMMWKkkOXWMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMXxc:;;:;;:;;;:;;;;;c0WMWWXOkkOKXNNX0OkkKNMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMM0l:;;;;;::;::;;;;;:ckNMMMWX0OkkkOOkkkOKNMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMWKdc:;;:;;;;;;;;;cd0NMMMMMMWNXK0000KXWWMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMWKdc:;;:;;:;:cd0NMMMMMMMMMMMMWWWWMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMWWXKXNWMWKdc:;;;;cd0NMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMWNK0kkkOKNWMWKxc:cd0NMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MNKKXNNX0kkkkkkk0NMMMWXKKWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
WXOkkOOkkkkkkkkOXWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MWX0OkkkkkkkkOKNWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMWX0OkkkkOKNWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMWX0OkkOKWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMWX0OkOXMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMWNXNWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
There was a problem hiding this comment.
Added more 💰💰💰:
$$$$$$\ $$$$$$$$\ $$\ $$\
$$ __$$\ \__$$ __| $$ | $$ |
$$ / $$ | $$$$$$\ $$$$$$\ $$$$$$$\ $$ | $$$$$$\ $$ | $$$$$$\ $$$$$$\$$$$\ $$$$$$\ $$$$$$\ $$$$$$\ $$\ $$\
$$ | $$ |$$ __$$\ $$ __$$\ $$ __$$\ $$ |$$ __$$\ $$ |$$ __$$\ $$ _$$ _$$\ $$ __$$\\_$$ _| $$ __$$\ $$ | $$ |
$$ | $$ |$$ / $$ |$$$$$$$$ |$$ | $$ |$$ |$$$$$$$$ |$$ |$$$$$$$$ |$$ / $$ / $$ |$$$$$$$$ | $$ | $$ | \__|$$ | $$ |
$$ | $$ |$$ | $$ |$$ ____|$$ | $$ |$$ |$$ ____|$$ |$$ ____|$$ | $$ | $$ |$$ ____| $$ |$$\ $$ | $$ | $$ |
$$$$$$ |$$$$$$$ |\$$$$$$$\ $$ | $$ |$$ |\$$$$$$$\ $$ |\$$$$$$$\ $$ | $$ | $$ |\$$$$$$$\ \$$$$ |$$ | \$$$$$$$ |
\______/ $$ ____/ \_______|\__| \__|\__| \_______|\__| \_______|\__| \__| \__| \_______| \____/ \__| \____$$ |
$$ | $$\ $$ |
$$ | \$$$$$$ |
\__| \______/
There was a problem hiding this comment.
The beauty of the install that is the opentelemetry-demo chart
=======================================================================================
██████╗ ████████╗███████╗██╗ ██████╗ ███████╗███╗ ███╗ ██████╗
██╔═══██╗╚══██╔══╝██╔════╝██║ ██╔══██╗██╔════╝████╗ ████║██╔═══██╗
██║ ██║ ██║ █████╗ ██║ ██║ ██║█████╗ ██╔████╔██║██║ ██║
██║ ██║ ██║ ██╔══╝ ██║ ██║ ██║██╔══╝ ██║╚██╔╝██║██║ ██║
╚██████╔╝ ██║ ███████╗███████╗ ██████╔╝███████╗██║ ╚═╝ ██║╚██████╔╝
╚═════╝ ╚═╝ ╚══════╝╚══════╝ ╚═════╝ ╚══════╝╚═╝ ╚═╝ ╚═════╝
Codecov Report
@@ Coverage Diff @@
## main #3557 +/- ##
==========================================
+ Coverage 87.12% 87.17% +0.05%
==========================================
Files 275 275
Lines 9959 9959
==========================================
+ Hits 8677 8682 +5
+ Misses 1282 1277 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #3556, #3548 (comment) and #3548 (comment).