Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit workflow fix to keep CI greener #3548

Merged
merged 8 commits into from
Aug 4, 2022

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Aug 4, 2022

image

^ ->?

@cijothomas cijothomas requested a review from a team August 4, 2022 23:10
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #3548 (0f7173d) into main (aba6eaf) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3548      +/-   ##
==========================================
+ Coverage   87.07%   87.22%   +0.15%     
==========================================
  Files         275      275              
  Lines        9959     9959              
==========================================
+ Hits         8672     8687      +15     
+ Misses       1287     1272      -15     
Impacted Files Coverage Δ
...Propagators/OpenTelemetryPropagatorsEventSource.cs 87.50% <0.00%> (-12.50%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 75.00% <0.00%> (-10.00%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 78.04% <0.00%> (-2.44%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 76.66% <0.00%> (-0.84%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 94.50% <0.00%> (+3.29%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

@cijothomas
Copy link
Member Author

image
success!

@cijothomas cijothomas merged commit 0be837f into open-telemetry:main Aug 4, 2022

jobs:
check-format:
runs-on: ubuntu-latest

steps:
- run: 'echo "No build required"'
- run: 'echo "No build required"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought to myself... 🐇 approved a PR without a newline at the end of the file?! BUT then I opened up the resolved comment #3548 (comment) 😆. #3556

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a cop here #3557.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants