Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sanity check to cover .github and .vscode folders #3557

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Update sanity check to cover .github and .vscode folders #3557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9dc03d
update sanity checks to cover .github folder
reyang Aug 5, 2022
8f2b978
cover .vscode folder
reyang Aug 5, 2022
6e1cc4d
Merge branch 'main' into reyang/sanity
reyang Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name: "CodeQL"

on:
schedule:
- cron: '0 0 * * *' # once in a day at 00:00
- cron: '0 0 * * *' # once in a day at 00:00

jobs:
analyze:
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main

Expand All @@ -49,12 +49,12 @@ jobs:
- name: Autobuild
uses: github/codeql-action/autobuild@v2

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
Comment on lines -52 to -53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but but... I like emojis. Can we have sanitycheck require minimum one emoji per file?

Copy link
Member Author

@reyang reyang Aug 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an emoji for OpenTelemetry (maybe 🔭📺📊📈📉)? Might be a good thing (although it's not friendly to developers who use Notepad.exe or vi via telnet) 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(although it's not friendly to developers who use Notepad.exe or vi via telnet)

I have a solution:

MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWX0KNWMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWX0OkkOKNWMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWX0OkkkkkkOKNWMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMNKOkkkkkkkkkkOKNWMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMN0kkkkkkkkkkkkkOKNWMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWNKOkkkkkkkkkkkkkOKNWMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWNKOkkkkkkkkkkkkkOKNWMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXOkOXWMWNKOkkkkkkkkkkkkkOKNWMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXkl:;:cxKWMWNKOkkkkkkkkkkkkkOKNWMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWWXkl:;;:;;:lxKWMWNKOkkkkkkkkkkkkkOKNWM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXkdl:;:;;;;;;;:cxKWMWNKOkkkkkkkkkkkkkOXW
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXkl:;;;;:;;;;;;;;::cxKWMWNKOkkkkkkkkkkkOKW
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWXkl:::;;;;::;;;:;;:;;;:cxKWMWNKOkkkkkkkO0XWM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMKo:;;;;:;;:;;;;;;;;;::;;;:cxKWMWNKOkkkO0XWMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMKo:;;;;;;;;;;;;;;;;:;;:;;:;:ckNMMWNKKKXWMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMNOl:;;::;;;;;;;;;;;;;;;;;;;:dXMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMNOo:::;;::ccllcc:;:;;:;:lkXWMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMWKkdx0NMMXOxooxO0XXNNXK0kdl::lkXWMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMW0dc:;;:d0NMMWWWWMMWWWWWMMMWXOOXWMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMW0dc;::;;;:cOWMMMMWXK00OO0KXNWMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMW0dc:;;;;;;;:oKMMMWX0kkkOOOOkkOKNMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMW0dc:;;;;;;;;;l0WMWNKOkk0XNWNNKOkk0NMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMW0dc;;;;;;;;;;;;oXMMNK0kk0NMMMMMWKkkOKWMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMW0dc;;;;;:;;;;;;;;oXMMNX0kk0NMMMMMWKkkOXWMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMXxc:;;:;;:;;;:;;;;;c0WMWWXOkkOKXNNX0OkkKNMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMM0l:;;;;;::;::;;;;;:ckNMMMWX0OkkkOOkkkOKNMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMWKdc:;;:;;;;;;;;;cd0NMMMMMMWNXK0000KXWWMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMWKdc:;;:;;:;:cd0NMMMMMMMMMMMMWWWWMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMWWXKXNWMWKdc:;;;;cd0NMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMWNK0kkkOKNWMWKxc:cd0NMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MNKKXNNX0kkkkkkk0NMMMWXKKWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
WXOkkOOkkkkkkkkOXWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MWX0OkkkkkkkkOKNWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMWX0OkkkkOKNWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMWX0OkkOKWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMWX0OkOXMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMWNXNWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more 💰💰💰:

 $$$$$$\                             $$$$$$$$\        $$\                                    $$\                         
$$  __$$\                            \__$$  __|       $$ |                                   $$ |                        
$$ /  $$ | $$$$$$\   $$$$$$\  $$$$$$$\  $$ | $$$$$$\  $$ | $$$$$$\  $$$$$$\$$$$\   $$$$$$\ $$$$$$\    $$$$$$\  $$\   $$\ 
$$ |  $$ |$$  __$$\ $$  __$$\ $$  __$$\ $$ |$$  __$$\ $$ |$$  __$$\ $$  _$$  _$$\ $$  __$$\\_$$  _|  $$  __$$\ $$ |  $$ |
$$ |  $$ |$$ /  $$ |$$$$$$$$ |$$ |  $$ |$$ |$$$$$$$$ |$$ |$$$$$$$$ |$$ / $$ / $$ |$$$$$$$$ | $$ |    $$ |  \__|$$ |  $$ |
$$ |  $$ |$$ |  $$ |$$   ____|$$ |  $$ |$$ |$$   ____|$$ |$$   ____|$$ | $$ | $$ |$$   ____| $$ |$$\ $$ |      $$ |  $$ |
 $$$$$$  |$$$$$$$  |\$$$$$$$\ $$ |  $$ |$$ |\$$$$$$$\ $$ |\$$$$$$$\ $$ | $$ | $$ |\$$$$$$$\  \$$$$  |$$ |      \$$$$$$$ |
 \______/ $$  ____/  \_______|\__|  \__|\__| \_______|\__| \_______|\__| \__| \__| \_______|  \____/ \__|       \____$$ |
          $$ |                                                                                                 $$\   $$ |
          $$ |                                                                                                 \$$$$$$  |
          \__|                                                                                                  \______/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beauty of the install that is the opentelemetry-demo chart

=======================================================================================


 ██████╗ ████████╗███████╗██╗         ██████╗ ███████╗███╗   ███╗ ██████╗ 
██╔═══██╗╚══██╔══╝██╔════╝██║         ██╔══██╗██╔════╝████╗ ████║██╔═══██╗
██║   ██║   ██║   █████╗  ██║         ██║  ██║█████╗  ██╔████╔██║██║   ██║
██║   ██║   ██║   ██╔══╝  ██║         ██║  ██║██╔══╝  ██║╚██╔╝██║██║   ██║
╚██████╔╝   ██║   ███████╗███████╗    ██████╔╝███████╗██║ ╚═╝ ██║╚██████╔╝
 ╚═════╝    ╚═╝   ╚══════╝╚══════╝    ╚═════╝ ╚══════╝╚═╝     ╚═╝ ╚═════╝

# Command-line programs to run using the OS shell.
# https://git.io/JvXDl

# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language
# If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language

#- run: |
# make bootstrap
Expand Down
3 changes: 3 additions & 0 deletions build/sanitycheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ def sanitycheck(pattern, allow_utf8 = False, allow_eol = (CRLF, LF), indent = 1)

retval = 0
retval += sanitycheck('.editorconfig', allow_eol = (LF,), indent = 0)
retval += sanitycheck('.github/**/*.md', allow_eol = (LF,))
retval += sanitycheck('.github/**/*.yml', allow_eol = (LF,), indent = 2)
retval += sanitycheck('.vscode/**/*.json', allow_eol = (LF,), indent = 2)
retval += sanitycheck('**/Dockerfile', allow_eol = (LF,), indent = 2)
retval += sanitycheck('**/*.cmd', allow_eol = (CRLF,), indent = 2)
retval += sanitycheck('**/*.config', allow_utf8 = True, allow_eol = (LF,), indent = 2)
Expand Down