Dev/twegner/issue 83 #157
Merged
Dev/twegner/issue 83 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging open-telemetry/opentelemetry-dotnet master
…try-dotnet Merging upstream master
Merging upstream master
…rals with nameof().
trwegner
requested review from
austinlparker,
discostu105,
lmolkova and
SergeyKanzhelev
as code owners
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are focused on the following:
Utilize string.Concat() instead of string interpolation for performance improvement pointed to in issue Collections util methods may be unnecessary #83
Eliminate string literals in favor of using nameof() for class and method names in ToString() overrides for improved maintainability.
Note that Collections.cs referenced in issue #83 has been removed so the collection utility methods are already gone.