Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I suggest we start with the copy of OpenCensus SDK #1

Closed
SergeyKanzhelev opened this issue May 7, 2019 · 4 comments
Closed

I suggest we start with the copy of OpenCensus SDK #1

SergeyKanzhelev opened this issue May 7, 2019 · 4 comments

Comments

@SergeyKanzhelev
Copy link
Member

No description provided.

@gregkalapos
Copy link
Member

Hey @SergeyKanzhelev,

I'd be very happy to contribute. Is there any plan on how to move forward? Do we have any "actionable" items for the .NET implementation?

Also to be not totally off topic: 👍 for starting with the copy of OpenCensus SDK.

@austinlparker
Copy link
Member

+1

@SergeyKanzhelev
Copy link
Member Author

@gregkalapos, @austinlparker great! There are a few smaller items still hanging from OpenCensus repo. If you want to get started right away - find some inspiration in those issues.

I will start posting issues and later a plan. Plus will set up some weekly sync-ups.

On the high level, I think we can scope September release to API updates to match OpenTelemetry specs and release quality implementation. Plus prod quality autocollectors for ASP.NET Core and System.Net.Http and exporters for Zipkin and Prometheus as a minimum.

@austinlparker
Copy link
Member

sgtm - I think the OT bridge should be pretty straightforward as well.

@gregkalapos gregkalapos mentioned this issue May 9, 2019
cijothomas added a commit that referenced this issue Aug 5, 2020
* Creating CompositePropagator

Adding ActivityContext to interface

Adding tests

Updating CompositePropagator + tests

updating comments

Improving performance when size is 0

updating tests

updating default tracestate for empty

MikeGoldsmith review

adding more tests to exemplify usage

Feature/composite propagator refactor (#1)

* Added TestPropagator and switched a couple tests to use it.

* removing extra classes

Co-authored-by: Mikel Blanchard <[email protected]>

updating changelog and constructor

MikeGoldsmith comments

updating logic

* checking value

* adding inverted test

* updating tests

* removing tracecontext and b3 tests

* testing only aspnet to merge

* Revert "testing only aspnet to merge"

This reverts commit 43ca7d0.

Co-authored-by: Cijo Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants