Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections util methods may be unnecessary #83

Closed
SergeyKanzhelev opened this issue Jun 3, 2019 · 5 comments
Closed

Collections util methods may be unnecessary #83

SergeyKanzhelev opened this issue Jun 3, 2019 · 5 comments
Assignees
Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package

Comments

@SergeyKanzhelev
Copy link
Member

See comments here:

census-instrumentation/opencensus-csharp#41 (review)

image

@SergeyKanzhelev SergeyKanzhelev added the pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package label Jun 11, 2019
@SergeyKanzhelev SergeyKanzhelev added this to the SDK complete milestone Jun 11, 2019
@trwegner
Copy link
Contributor

Please assign this issue to me.

@austinlparker
Copy link
Member

@trwegner done, enjoy!

@trwegner
Copy link
Contributor

thanks @austinlparker. wondering if there are objections to also converting to use nameof() in these methods to eliminate literal string for class and member names:

    public override string ToString()
    {
        return "Status{"
                + "canonicalCode=" + this.CanonicalCode + ", "
                + "description=" + this.Description
                + "}";
    }

would change to

    public override string ToString()
    {
        return nameof(Status) + "{"
                + nameof(this.CanonicalCode) + "=" + this.CanonicalCode + ", "
                + nameof(this.Description) + "=" + this.Description
                + "}";
    }

@austinlparker
Copy link
Member

works for me

lmolkova pushed a commit that referenced this issue Jul 22, 2019
@lmolkova
Copy link

I believe this was fixed in some clean up round. There are no more Collections utils

Yun-Ting pushed a commit to Yun-Ting/opentelemetry-dotnet that referenced this issue Oct 13, 2022
* Upgrading Elasticsearch to OTel version to 1.0.1

* Update OTel to make use of AddLegacyActivity

* Add shared project for instrumentation helper source

* Added an Elasticsearch sampler tests (currently fails)

* Got tests passing and add tests to show that sampling is working

* Move constants into ElasticsearchRequestPipelineDiagnosticListener class. Fix formatting issues.

* Adding Enrich option for Elasticsearch instrumentation

* Skip shared project test coverage

* Add tests to verify downstream suppression. Change DiagnosticSourceListener to use it's own RuntimeContextSlot.

* Update to latest OTel

Co-authored-by: Cijo Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package
Projects
None yet
Development

No branches or pull requests

4 participants