-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collections util methods may be unnecessary #83
Labels
pkg:OpenTelemetry.Api
Issues related to OpenTelemetry.Api NuGet package
Comments
SergeyKanzhelev
added
the
pkg:OpenTelemetry.Api
Issues related to OpenTelemetry.Api NuGet package
label
Jun 11, 2019
Please assign this issue to me. |
@trwegner done, enjoy! |
thanks @austinlparker. wondering if there are objections to also converting to use nameof() in these methods to eliminate literal string for class and member names:
would change to
|
works for me |
Merged
I believe this was fixed in some clean up round. There are no more Collections utils |
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this issue
Oct 13, 2022
* Upgrading Elasticsearch to OTel version to 1.0.1 * Update OTel to make use of AddLegacyActivity * Add shared project for instrumentation helper source * Added an Elasticsearch sampler tests (currently fails) * Got tests passing and add tests to show that sampling is working * Move constants into ElasticsearchRequestPipelineDiagnosticListener class. Fix formatting issues. * Adding Enrich option for Elasticsearch instrumentation * Skip shared project test coverage * Add tests to verify downstream suppression. Change DiagnosticSourceListener to use it's own RuntimeContextSlot. * Update to latest OTel Co-authored-by: Cijo Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See comments here:
census-instrumentation/opencensus-csharp#41 (review)
The text was updated successfully, but these errors were encountered: