Dev/twegner/issue 139 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging open-telemetry/opentelemetry-dotnet master
…try-dotnet Merging upstream master
Merging upstream master
trwegner
requested review from
austinlparker,
discostu105,
lmolkova and
SergeyKanzhelev
as code owners
austinlparker
approved these changes
Jul 16, 2019
lmolkova
approved these changes
Jul 16, 2019
|
@trwegner hate to ask, but can you take a look at this? some stuff merged today that needs synced up with your changes. |
|
@austinlparker and @lmolkova, I don't have auth to merge this change. any chance one of you could take care of that on my behalf? |
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
… configuration (open-telemetry#153) * Added TelemetryContractBehaviorAttribute to support programmatic configuration. * Updated PR link in README * Lint * Lint 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing ExportComponent and IExportComponent to address issue #139.
ExportComponent is not included in OpenTelemetry specification so should be removed. This was pointed out in PR 111 comments for issue #18 by @lmolkova on Tracing.cs.