Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExportComponent from SDK layer #139

Closed
trwegner opened this issue Jul 9, 2019 · 4 comments
Closed

Remove ExportComponent from SDK layer #139

trwegner opened this issue Jul 9, 2019 · 4 comments
Assignees
@trwegner
Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package

Comments

@trwegner
Copy link
Contributor

trwegner commented Jul 9, 2019

ExportComponent is not included in OpenTelemetry specification so should be removed. This was pointed out in PR 111 comments for issue #18 by @lmolkova on Tracing.cs.
@lmolkova
Copy link

@trwegner do you think you'll be able to take it over?

@SergeyKanzhelev SergeyKanzhelev added this to the API 0.1 complete milestone Jul 12, 2019
@SergeyKanzhelev SergeyKanzhelev added the pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package label Jul 12, 2019
@trwegner
Copy link
Contributor Author

trwegner commented Jul 12, 2019 via email

@lmolkova lmolkova mentioned this issue Jul 13, 2019
Merged
@lmolkova
Copy link

Sorry, already removed span stores in #147, they were very annoying :)

@trwegner trwegner mentioned this issue Jul 16, 2019
Merged
@lmolkova lmolkova mentioned this issue Sep 18, 2019
Closed
@lmolkova
Copy link

fixed in #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trwegner trwegner

Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lmolkova @trwegner @SergeyKanzhelev