Clean up #147
Merged
Clean up #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
austinlparker,
discostu105 and
SergeyKanzhelev
as code owners
added 7 commits
July 13, 2019 19:15
…remove EndSpanOptions and EndSpanOptionsBuilder
lmolkova
force-pushed
the
CleanUpRemoveThings
branch
from
93fb489 to
d4697f5
Compare
SergeyKanzhelev
approved these changes
Jul 15, 2019
|
Nice! |
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed:
timestamp - it is a class (read allocation) and there is a DateTime in .NET. .NET Framework timestamp is not precise.
PreciseTimestampsolves this problemTimer - this made sure child spans get relative timestamp from their parent. Not needed with Precise timestamp
Duration. There is .NET TimeSpan
Span Stores - their tests relied very heavily on Timestamp and mockable time. We wanted to remove them anyway in Remove ExportComponent from SDK layer #139
Collection utils
clean up SpanStartOptions, SpanEndOptions - and their builder - they are not part of spec, they require tons of allocations
clean up some properties on Span impl that come with Activity