Reintroduce System.Data.SqlClient trace instrumentation #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RassK
changed the title
|
Found missing test conditions > .NET Framework tests (Requires Windows host) and Linux container requirement. |
This comment was marked as outdated.
This comment was marked as outdated.
Kielek
reviewed
Nov 23, 2022
pellared
reviewed
Nov 23, 2022
pellared
approved these changes
Nov 23, 2022
RassK
commented
Nov 23, 2022
Kielek
approved these changes
Nov 23, 2022
|
One more thing, opentelemetry-dotnet-instrumentation/CHANGELOG.md Lines 24 to 25 in 8f33a92 |
Done in #1649 (it was easier this way to avoid conflicts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1623
What
Reintroduces
System.Data.SqlClientinstrumentation in lazy form.Increasing affected scope of #1638
Tests
Existing + NetFramework tests
Checklist
CHANGELOG.mdis updated.