Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.0 #1649

Merged
merged 18 commits into from
Nov 24, 2022
Merged

Release 0.5.0 #1649

merged 18 commits into from
Nov 24, 2022

Conversation

pellared
Copy link
Member

@pellared pellared commented Nov 23, 2022

Added

  • Add support for .NET 7.
  • Add support for OTEL_DOTNET_AUTO_LOGS_ENABLED.
  • Add error log if bytecode instrumentation type is missing all instrumentation methods.
  • Plugins can overwrite OpenTelemetry .NET SDK exporters' and instrumentations' options.

Changed

  • Replace OTEL_DOTNET_AUTO_LOAD_TRACER_AT_STARTUP with OTEL_DOTNET_AUTO_TRACES_ENABLED and OTEL_DOTNET_AUTO_LOAD_METER_AT_STARTUP with OTEL_DOTNET_AUTO_METRICS_ENABLED.
  • Disable OpenTracing by default. OpenTracing can be re-enabled via OTEL_DOTNET_AUTO_OPENTRACING_ENABLED.
  • GraphQL exceptions are recorded as OTel events.
  • DOTNET_STARTUP_HOOKS required value changed to $INSTALL_DIR/net/OpenTelemetry.AutoInstrumentation.StartupHook.dll.

Removed

  • Remove support for .NET Core 3.1.
  • Remove support for OTEL_DOTNET_AUTO_HTTP2UNENCRYPTEDSUPPORT_ENABLED.
  • Remove support for OTEL_DOTNET_AUTO_ENABLED. Use CORECLR_ENABLE_PROFILING or COR_ENABLE_PROFILING instead.
  • Remove support for OTEL_DOTNET_AUTO_INCLUDE_PROCESSES.

Fixed

  • Fix the IIS registration in the PowerShell script module for Windows Server 2016.
  • Fix the IIS unregistration in the PowerShell script module.
  • Get rid of unnecessary service restarts during the IIS unregistration, in the PowerShell script module.
  • OTEL_DOTNET_AUTO_TRACES_ENABLED is also respected by bytecode instrumentations.

@pellared
Copy link
Member Author

I want to give a chance to address #1623 before releasing.

@pellared pellared changed the title Release 0.5.0-beta.1 Release 0.5.0 Nov 23, 2022
@pellared
Copy link
Member Author

Giving a chance to address #1644 before releasing

@pellared
Copy link
Member Author

The scripts would need to be updated once #1661 is merged

@pellared pellared marked this pull request as ready for review November 24, 2022 11:44
@pellared pellared requested a review from a team November 24, 2022 11:44
@pellared
Copy link
Member Author

pellared commented Nov 24, 2022

I tested locally via nuke Workflow --containers linux on Windows

@dszmigielski did the same on macOS

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. Please confirm behavior for OpenTelemetry.AutoInstrumentation.AspNetCoreBootstrapper.

@pellared
Copy link
Member Author

pellared commented Nov 24, 2022

PR looks good. Please confirm behavior for OpenTelemetry.AutoInstrumentation.AspNetCoreBootstrapper.

@Kielek On .NET Core 3.1 and .NET 5.0 we the get following log, but the application does NOT crash:

crit: Microsoft.AspNetCore.Hosting.Diagnostics[11]
      Hosting startup assembly exception
      System.InvalidOperationException: Startup assembly OpenTelemetry.AutoInstrumentation.AspNetCoreBootstrapper failed to execute. See the inner exception for more details.
       ---> System.IO.FileNotFoundException: Could not load file or assembly 'OpenTelemetry.AutoInstrumentation.AspNetCoreBootstrapper, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.
      File name: 'OpenTelemetry.AutoInstrumentation.AspNetCoreBootstrapper, Culture=neutral, PublicKeyToken=null'
         at System.Reflection.RuntimeAssembly.InternalLoad(ObjectHandleOnStack assemblyName, ObjectHandleOnStack requestingAssembly, StackCrawlMarkHandle stackMark, Boolean throwOnFileNotFound, ObjectHandleOnStack assemblyLoadContext, ObjectHandleOnStack retAssembly)
         at System.Reflection.RuntimeAssembly.InternalLoad(AssemblyName assemblyName, RuntimeAssembly requestingAssembly, StackCrawlMark& stackMark, Boolean throwOnFileNotFound, AssemblyLoadContext assemblyLoadContext)
         at System.Reflection.Assembly.Load(AssemblyName assemblyRef)
         at Microsoft.AspNetCore.Hosting.GenericWebHostBuilder.ExecuteHostingStartups()
         --- End of inner exception stack trace ---

I think it is good enough. Do you agree?

@pellared
Copy link
Member Author

@pellared pellared merged commit 773dce6 into open-telemetry:main Nov 24, 2022
@pellared pellared deleted the release-0.5.0-beta.1 branch November 24, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants