-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.5.0 #1649
Release 0.5.0 #1649
Conversation
I want to give a chance to address #1623 before releasing. |
Giving a chance to address #1644 before releasing |
The scripts would need to be updated once #1661 is merged |
I tested locally via @dszmigielski did the same on macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. Please confirm behavior for OpenTelemetry.AutoInstrumentation.AspNetCoreBootstrapper
.
@Kielek On .NET Core 3.1 and .NET 5.0 we the get following log, but the application does NOT crash:
I think it is good enough. Do you agree? |
Testing the release workflow before merging: https://github.com/pellared/opentelemetry-dotnet-instrumentation/actions/runs/3540850200 |
Added
OTEL_DOTNET_AUTO_LOGS_ENABLED
.Changed
OTEL_DOTNET_AUTO_LOAD_TRACER_AT_STARTUP
withOTEL_DOTNET_AUTO_TRACES_ENABLED
andOTEL_DOTNET_AUTO_LOAD_METER_AT_STARTUP
withOTEL_DOTNET_AUTO_METRICS_ENABLED
.OTEL_DOTNET_AUTO_OPENTRACING_ENABLED
.DOTNET_STARTUP_HOOKS
required value changed to$INSTALL_DIR/net/OpenTelemetry.AutoInstrumentation.StartupHook.dll
.Removed
OTEL_DOTNET_AUTO_HTTP2UNENCRYPTEDSUPPORT_ENABLED
.OTEL_DOTNET_AUTO_ENABLED
. UseCORECLR_ENABLE_PROFILING
orCOR_ENABLE_PROFILING
instead.OTEL_DOTNET_AUTO_INCLUDE_PROCESSES
.Fixed
OTEL_DOTNET_AUTO_TRACES_ENABLED
is also respected by bytecode instrumentations.