Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back System.Data.SqlClient trace instrumentation #1623

Closed
pellared opened this issue Nov 16, 2022 · 1 comment · Fixed by #1650
Closed

Bring back System.Data.SqlClient trace instrumentation #1623

pellared opened this issue Nov 16, 2022 · 1 comment · Fixed by #1650
Assignees
@RassK
Labels
enhancement New feature or request
Milestone
0.5.0

Comments

@pellared
Copy link
Member

pellared commented Nov 16, 2022 •
edited
Loading

Instrumentation for System.Data.SqlClient was not really working.

This issue is about bringing it back the instrumentation (and adding an integration tests) once open-telemetry/opentelemetry-dotnet-contrib#1739 is solved.
@pellared pellared added the enhancement New feature or request label Nov 16, 2022
@pellared pellared added this to the 0.5.2 milestone Nov 16, 2022
This was referenced Nov 16, 2022
Merged
Merged
@pellared pellared modified the milestones: 0.5.2, 0.5.0 Nov 23, 2022
@pellared
Copy link
Member Author

pellared commented Nov 23, 2022 •
edited
Loading

Looks like it is connected with .NET Framework 4.8.1.

We could try bringing it back and make sure that it is not crashing on .NET Framework 4.8.1.

We can have a Skip in integration tests if needed and have an issue to remove the Skip once .NET Framework 4.8.1 is fixed.

@pellared pellared mentioned this issue Nov 23, 2022
Merged
@RassK RassK mentioned this issue Nov 23, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RassK RassK

Labels
enhancement New feature or request
Projects
OpenTelemetry .NET Automatic Instrumentation
Archived in project
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Reintroduce System.Data.SqlClient trace instrumentation RassK/opentelemetry-dotnet-instrumentation
2 participants
@RassK @pellared