Make SqlClient instrumentation lazy #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RassK <[email protected]>
RassK
commented
Nov 15, 2022
| private readonly PluginManager _pluginManager; | ||
|
|
||
| public SqlClientInitializer(PluginManager pluginManager) | ||
| : base("Microsoft.Data.SqlClient") |
There was a problem hiding this comment.
Do we also support System.Data.SqlClient? - I see we have no tests at least...
There was a problem hiding this comment.
Yes we do. Can you add a test as part of this PR?
There was a problem hiding this comment.
Good, I'll do this all within this PR 👍
There was a problem hiding this comment.
Unfortunately broken on .NET Framework https://github.com/open-telemetry/opentelemetry-dotnet/issues/3901
There was a problem hiding this comment.
I suggest removing support for System.Data.SqlClient until it is fixed (config.md must be updated)
There was a problem hiding this comment.
I will make a separate PR and issue.
pjanotti
reviewed
Nov 15, 2022
pellared
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards open-telemetry/opentelemetry-dotnet#1437
What
Tests
Existing
Checklist
CHANGELOG.mdis updated.