Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace outdated tool dotnet-format by the built-in dotnet format #1274

Closed
Kielek opened this issue Jul 20, 2023 · 0 comments · Fixed by #1339
Closed

Replace outdated tool dotnet-format by the built-in dotnet format #1274

Kielek opened this issue Jul 20, 2023 · 0 comments · Fixed by #1339
Labels
good first issue Good for newcomers help wanted Extra attention is needed infra Infra work - CI/CD, code coverage, linters

Comments

@Kielek
Copy link
Contributor

Kielek commented Jul 20, 2023 •
edited
Loading

BTW, it seems we are using an outdated tool dotnet-format instead of the built-in dotnet format subcommand in CI. The former seems to be completely confused by raw string literals.

Originally posted by @Oberon00 in #1270 (comment)

Similar changes done in autoinstrumentation repository open-telemetry/opentelemetry-dotnet-instrumentation#2694 and
https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/2614/files
@Kielek Kielek added good first issue Good for newcomers help wanted Extra attention is needed infra Infra work - CI/CD, code coverage, linters labels Jul 20, 2023
@ErtanTaner ErtanTaner mentioned this issue Jul 23, 2023
Closed
3 tasks
@Kielek Kielek mentioned this issue Aug 31, 2023
Closed
1 task
@CodeBlanch CodeBlanch mentioned this issue Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Milestone
No milestone
1 participant
@Kielek