Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default dotnet format #2694

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

pjanotti
Copy link
Contributor

Why

No need for devs or CI to install it as a tool since dotnet format is part of the SDK, see https://github.com/dotnet/format#how-to-use

What

Removed tool installation step

Tests

N/A

Checklist

- [ ] CHANGELOG.md is updated.
- [ ] Documentation is updated.
- [ ] New features are covered by tests.

@pjanotti pjanotti requested a review from a team June 22, 2023 20:34
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, few weeks ago, when I was trying to do the same, it was not working. Newer dotnet sdk and it seems to be fixed :)

@Kielek Kielek merged commit 785a53b into open-telemetry:main Jun 23, 2023
@pjanotti pjanotti deleted the use-default-dotnet-format branch June 23, 2023 04:19
@pjanotti
Copy link
Contributor Author

Great, few weeks ago, when I was trying to do the same, it was not working. Newer dotnet sdk and it seems to be fixed :)

true, it was dotnet/sdk#32598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants