Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo+ci] Use SDK dotnet format in CI #1339

Merged
merged 7 commits into from
Sep 7, 2023
Merged

[repo+ci] Use SDK dotnet format in CI #1339

merged 7 commits into from
Sep 7, 2023

Conversation

CodeBlanch
Copy link
Member

Fixes #1274

Changes

  • Updates the dotnet-format ci workflow to use the SDK version
  • Cleans up new warnings manifested by dotnet format
  • Removes EnableAnalysis property as it is now globally enabled in common props

@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #1339 (1c28c8e) into main (ebc40a0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage   74.50%   74.50%           
=======================================
  Files         266      266           
  Lines        9657     9657           
=======================================
  Hits         7195     7195           
  Misses       2462     2462
Files Changed Coverage
.../OpenTelemetry.Sampler.AWS/AWSXRaySamplerClient.cs 100.00%
src/Shared/ExceptionExtensions.cs 100.00%

📢 Thoughts on this report? Let us know!.

@CodeBlanch CodeBlanch marked this pull request as ready for review August 31, 2023 22:48
@CodeBlanch CodeBlanch requested a review from a team August 31, 2023 22:48
@Kielek Kielek added the infra Infra work - CI/CD, code coverage, linters label Sep 1, 2023
@Kielek Kielek merged commit a5a584e into open-telemetry:main Sep 7, 2023
@CodeBlanch CodeBlanch deleted the dotnet-format-ci-update branch September 7, 2023 19:25
@CodeBlanch CodeBlanch mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@Kielek Kielek Kielek approved these changes

@twenzel twenzel twenzel approved these changes

Assignees

@twenzel twenzel

@hananiel hananiel

@cijothomas cijothomas

@Havret Havret

@rajkumar-rangaraj rajkumar-rangaraj

@mic-max mic-max

@reyang reyang

@CodeBlanch CodeBlanch

@srprash srprash

@utpilla utpilla

Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace outdated tool dotnet-format by the built-in dotnet format