build: use built-in formatter

[ErtanTaner]

Fixes #1274.

Changes

I changed outadated formatter with built-in one.

For significant contributions please make sure you have completed the following items:

• Appropriate CHANGELOG.md updated for non-trivial changes
• Design discussion issue #
• Changes in public API reviewed

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: BurakTaner / name: Burak Taner (42f68a1, 7cb46ce, f9c34e3, e743b42, 38dc6cc)

[Kielek]

@BurakTaner,
please sign EasyCLA before we can proceed.
I suppose that it will detect some issues which we need to fix together with this merge.

[ErtanTaner]

Hi @Kielek, I tried to sign EasyCLa with your email and name-surname but gave me error "Company not found". My first time with EasyCLA, can you give a little help?

[Kielek]

@BurakTaner, you have two options

1. Register as individual contributor
2. Register as a part of the company were you working on. It depends on when you want to contribute to OTel repositories. In this case you have to find manager in your company to proceed.

[ErtanTaner]

@Kielek I signed CLA and pushed last changes to make branch up to date with main. What should ı do next?

[utpilla]

If it's part of the newer .NET SDK, then do we still need to install dotnet-format?

[utpilla]

Do we need to specify the .sln file?

[utpilla]

Could you simplify this command by removing the parameter for providing the .sln file?

[ErtanTaner]

I tried to use withtout specify the sln but gives me error. I checked from documentation and they said "If you don't specify a a file, going to check for current directory to found a solution" but it's not in my local computer.

[utpilla]

Since this PR does not change any .cs file or .editorconfig, the dotnet format check is not being triggered. We need to ensure that this check works correctly before we merge this PR. You might have to update a .cs file and then check the dotnet-format run, before undoing the change to the .cs file.

[Kielek]

@BurakTaner, I have pushed two commit to your branch

1. typo fix to execute real dotnet-format build
2. drop installation for obsolete tool.

Please check what you can do with detected issues https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/5676698870/job/15383851038?pr=1276

[ErtanTaner]

Branch was not up to date with the current changes and ı accidently force pushed. That's remove your commits, ı am so sorry about it. Going to make those changes again.

[ErtanTaner]

@Kielek @utpilla I tried to use format without errors in my machine and it's only works if ı build before the format process. The old one (dotnet-format) don't need this. Idk what is related to and how could ı fix it. Should ı add a build step in yml or are we going to use the old one ?

[Kielek]

I see a lot of issues similar to

Required references did not load for OpenTelemetry.Contrib.Tests.Shared or referenced project. Run `dotnet restore` prior to formatting.

I think that you have 2 options to proceed

1. Add separate step which will restore packages before current one
2. Remove --no-restore from current command.

I think the first option should be better to have separate time measurement for just code formatting.

Keeping the old version is not good idea - it is not supporting new C# futures so it will prevent us using it.

[codecov]

Codecov Report

Merging #1276 (38dc6cc) into main (e0eeb0a) will increase coverage by 0.29%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   73.83%   74.13%   +0.29%     
==========================================
  Files         264      256       -8     
  Lines        9386     9344      -42     
==========================================
- Hits         6930     6927       -3     
+ Misses       2456     2417      -39     

Files Changed	Coverage Δ
...ry.Exporter.Geneva/TLDExporter/TldTraceExporter.cs	32.31% <ø> (ø)
...on.AWS/Implementation/AWSTracingPipelineHandler.cs	87.75% <ø> (ø)
...tion.AWS/Implementation/SnsRequestContextHelper.cs	95.00% <ø> (ø)
...tion.AWS/Implementation/SqsRequestContextHelper.cs	95.00% <ø> (ø)
...ntation.AWSLambda/Implementation/AWSLambdaUtils.cs	81.57% <ø> (ø)
...ResourceDetectors.Azure/AzureVmMetadataResponse.cs	94.28% <ø> (ø)
src/OpenTelemetry.Sampler.AWS/RateLimiter.cs	100.00% <ø> (ø)
...c/OpenTelemetry.Sampler.AWS/RateLimitingSampler.cs	100.00% <ø> (ø)
...Lambda/Implementation/AWSLambdaResourceDetector.cs	100.00% <100.00%> (ø)
...ation.AWSLambda/TracerProviderBuilderExtensions.cs	100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

[ErtanTaner]

@Kielek Like ı said, ı tried to use format in my computer and without dotnet build, still gave the error like the last checks. Should ı include a dotnet build step or is there any problem am ı missing because ı already added restore step to yml file?

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.