Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configgrpc] Remove deprecated ServerConfig.ToListener #9583

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Feb 13, 2024

Updates #9481

@dmitryax dmitryax force-pushed the remove-deprecated-ToListener branch from 2561542 to 243a8a2 Compare February 13, 2024 23:48
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d455bff) 90.57% compared to head (243a8a2) 90.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9583   +/-   ##
=======================================
  Coverage   90.57%   90.58%           
=======================================
  Files         347      347           
  Lines       18244    18242    -2     
=======================================
  Hits        16524    16524           
+ Misses       1390     1388    -2     
  Partials      330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like we need to fix contrib first

@TylerHelmuth
Copy link
Member

@dmitryax dmitryax merged commit 59b45a5 into open-telemetry:main Feb 14, 2024
46 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 14, 2024
@dmitryax dmitryax deleted the remove-deprecated-ToListener branch February 15, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants