Skip to content

Commit

Permalink
[configgrpc] Remove deprecated ServerConfig.ToListener
Browse files Browse the repository at this point in the history
  • Loading branch information
dmitryax committed Feb 13, 2024
1 parent d455bff commit 2561542
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 6 deletions.
25 changes: 25 additions & 0 deletions .chloggen/remove_ServerConfig_ToListener.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: configgrpc

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove deprecated `configgrpc.ServerConfig.ToListener`

# One or more tracking issues or pull requests related to the change
issues: [9583]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
6 changes: 0 additions & 6 deletions config/configgrpc/configgrpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,6 @@ func (gss *ServerConfig) ToListenerContext(ctx context.Context) (net.Listener, e
return gss.NetAddr.Listen(ctx)
}

// ToListener returns the net.Listener constructed from the settings.
// Deprecated: [v0.94.0] Call Listen directly on the NetAddr field.
func (gss *ServerConfig) ToListener() (net.Listener, error) {
return gss.ToListenerContext(context.Background())
}

func (gss *ServerConfig) ToServer(host component.Host, settings component.TelemetrySettings, extraOpts ...grpc.ServerOption) (*grpc.Server, error) {
opts, err := gss.toServerOption(host, settings)
if err != nil {
Expand Down

0 comments on commit 2561542

Please sign in to comment.