Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config/configgrpc] [chore] Remove usage of deprecated ToListenerContext #9582

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

dmitryax
Copy link
Member

Not sure why the linter doesn't catch it

@dmitryax dmitryax requested review from a team and codeboten February 13, 2024 23:14
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (ae90430) to head (f68c6ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9582   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files         347      347           
  Lines       18210    18210           
=======================================
  Hits        16515    16515           
  Misses       1371     1371           
  Partials      324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax force-pushed the remove-deprecated-var-usage branch from 89ce154 to b296f18 Compare February 13, 2024 23:20
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the deprecation comment on ToListener can the whole function be removed?

@dmitryax
Copy link
Member Author

Based on the deprecation comment on ToListener can the whole function be removed?

It can be. It's a bit unrelated tho. I can submit another PR

@dmitryax dmitryax force-pushed the remove-deprecated-var-usage branch from b296f18 to 1f3e762 Compare February 13, 2024 23:41
@dmitryax
Copy link
Member Author

@TylerHelmuth , #9583

@dmitryax dmitryax force-pushed the remove-deprecated-var-usage branch from 1f3e762 to f68c6ac Compare February 22, 2024 20:34
@dmitryax dmitryax merged commit 1ce9c93 into open-telemetry:main Feb 22, 2024
46 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 22, 2024
@dmitryax dmitryax deleted the remove-deprecated-var-usage branch February 22, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants