Refactor pipelines builder, fix some issues #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5512 +/- ##
=======================================
Coverage 90.94% 90.94%
=======================================
Files 191 191
Lines 11381 11381
=======================================
Hits 10350 10350
Misses 808 808
Partials 223 223 Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
refactorbuilder
branch
from
0dc8437 to
c162af3
Compare
|
@mx-psi converting for the moment to draft, since this PR is too large, will send smaller PRs tomorrow |
|
👍 Ping me when the PRs are ready to review |
bogdandrutu
force-pushed
the
refactorbuilder
branch
2 times, most recently
from
560ca13 to
886c68a
Compare
bogdandrutu
force-pushed
the
refactorbuilder
branch
2 times, most recently
from
94d0951 to
787b1bb
Compare
This was referenced Jun 15, 2022
bogdandrutu
force-pushed
the
refactorbuilder
branch
from
787b1bb to
1e0f604
Compare
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
refactorbuilder
branch
2 times, most recently
from
949fa14 to
5a5cfc2
Compare
|
@mx-psi please review, now this PR is well documented and ready for the final review. |
bogdandrutu
force-pushed
the
refactorbuilder
branch
2 times, most recently
from
e6b783c to
f708e0e
Compare
mx-psi
approved these changes
Jun 21, 2022
bogdandrutu
force-pushed
the
refactorbuilder
branch
from
f708e0e to
15dc205
Compare
bogdandrutu
force-pushed
the
refactorbuilder
branch
2 times, most recently
from
2d87748 to
8c64dae
Compare
* Unconfigured receivers are not identified, this was not a real problem in final binaries since the validation of the config catch this. * Allow configurations to contain "unused" receivers. Receivers that are configured but not used in any pipeline, this was possible already for exporters and processors. * Remove the enforcement/check that Receiver factories create the same instance for the same config. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
refactorbuilder
branch
from
8c64dae to
1bed598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]