-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the new pipelines builder #5544
Conversation
bcbdd10
to
ae5e52a
Compare
Codecov Report
@@ Coverage Diff @@
## main #5544 +/- ##
==========================================
+ Coverage 90.80% 90.99% +0.19%
==========================================
Files 194 194
Lines 11485 11485
==========================================
+ Hits 10429 10451 +22
+ Misses 833 818 -15
+ Partials 223 216 -7
Continue to review full report at Codecov.
|
ae5e52a
to
d7469ba
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
d7469ba
to
a354a07
Compare
t.Skip("This is a small issue with current implementation which will be fixed in #5512." + | ||
"In real binary this will not be hit, since the validation of the config will catch this issue in advance.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that we build the receivers by looking at configs, and if used in one pipeline we create/initialize it. With this logic if there is a receiver in a pipeline without a config we don't create/initialize it, but this is not a "Valid" config and fails config.Validate()
.
Depends on #5542