Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zpages logic for extension into the extension builder #5537

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and mx-psi June 14, 2022 17:13
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 14, 2022
@bogdandrutu
Copy link
Member Author

/cc @mx-psi this is the second PR extracted from #5512

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #5537 (f8a674d) into main (a88d448) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main    #5537   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files         191      191           
  Lines       11381    11375    -6     
=======================================
- Hits        10350    10345    -5     
+ Misses        808      807    -1     
  Partials      223      223           
Impacted Files Coverage Δ
service/service.go 46.15% <ø> (-1.35%) ⬇️
service/internal/extensions/extensions.go 83.83% <82.50%> (-1.50%) ⬇️
service/host.go 100.00% <100.00%> (ø)
service/zpages.go 76.04% <100.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a88d448...f8a674d. Read the comment docs.

@bogdandrutu bogdandrutu merged commit e77f3d4 into open-telemetry:main Jun 15, 2022
@bogdandrutu bogdandrutu deleted the extensions branch June 15, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants