Deprecate consumerprofiles module in favor of xconsumer #11779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
deprecate-consumerprofiles
branch
2 times, most recently
from
23958f7 to
721feee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11779 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 448 449 +1
Lines 23759 23761 +2
=======================================
+ Hits 21761 21763 +2
Misses 1623 1623
Partials 375 375 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
deprecate-consumerprofiles
branch
3 times, most recently
from
2e66074 to
17d1b76
Compare
bogdandrutu
approved these changes
Dec 2, 2024
|
Waiting for the vote results before merging |
dmitryax
force-pushed
the
deprecate-consumerprofiles
branch
from
17d1b76 to
ab29c2a
Compare
dmitryax
requested review from
dmathieu,
djaglowski,
evan-bradley,
andrzej-stencel and
codeboten
as code owners
dmitryax
changed the title
|
Updated PR according to the latest guidelines #11836 |
dmitryax
force-pushed
the
deprecate-consumerprofiles
branch
3 times, most recently
from
ad07225 to
81e22e5
Compare
dmathieu
approved these changes
Dec 11, 2024
dmitryax
force-pushed
the
deprecate-consumerprofiles
branch
from
81e22e5 to
65da351
Compare
mx-psi
approved these changes
Dec 12, 2024
This comment was marked as resolved.
This comment was marked as resolved.
dmitryax
force-pushed
the
deprecate-consumerprofiles
branch
from
65da351 to
06063af
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
dmitryax
force-pushed
the
deprecate-consumerprofiles
branch
2 times, most recently
from
ff91ccd to
6bc7547
Compare
To allow adding more experimental data types. First step towards open-telemetry#11778 Deprecate consumerprofiles module in favor of xconsumer
dmitryax
force-pushed
the
deprecate-consumerprofiles
branch
from
6bc7547 to
70ec24c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
#### Description `make update-otel` failed in contrib due to the new packages added in #11779. Pin a commit version for them in go mod to see if it unblocks contrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow adding more experimental data types. First step towards #11778