Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "profiles" modules to "experimental" #11778

Closed
dmitryax opened this issue Dec 2, 2024 · 0 comments
Closed

Rename "profiles" modules to "experimental" #11778

dmitryax opened this issue Dec 2, 2024 · 0 comments
Labels
release:blocker The issue must be resolved before cutting the next release

Comments

@dmitryax
Copy link
Member

dmitryax commented Dec 2, 2024

In order to add support for the new profiling data to any of the components, the component has to use the factories defined in experimental modules with profiles suffix, e.g. processorprofiles and exporterprofiles. The naming of the modules assumes that there is only one experimental module. If we want to add another experimental data signal (e.g. entities), it would be required to add it in the same modules so the components can support them together. However, the current naming schema is reserved for the profiling data type.

I propose we rename the experimental factory modules from processorprofiles to processorexp (or processorexperimental) etc. This can be done as a 2-step change without breaking existing users.

@dmitryax dmitryax changed the title Move "profiles" modules to "experimental" Rename "profiles" modules to "experimental" Dec 2, 2024
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 2, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 2, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of consumerexp
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 2, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of consumerexp
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 2, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of consumerexp
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 2, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of consumerexp
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 2, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of consumerexp
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 11, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 11, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 11, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 11, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 11, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 12, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 12, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 12, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this issue Dec 12, 2024
To allow adding more experimental data types. First step towards open-telemetry#11778

Deprecate consumerprofiles module in favor of xconsumer
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
To allow adding more experimental data types. First step towards
#11778
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2024
to allow adding more experimental data types

Updates
#11778
@songy23 songy23 added the release:blocker The issue must be resolved before cutting the next release label Dec 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2024
to allow adding more experimental data types

Updates
#11778
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2024
to allow adding more experimental data types.

Updates
#11778
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2024
to allow adding more experimental data types.

Updates
#11778
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2024
…1892)

to allow adding more experimental data types.

Updates
#11778
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2024
to allow adding more experimental data types.

Updates
#11778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

No branches or pull requests

2 participants