Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix xconsumer mod versions #11884

Merged
merged 2 commits into from
Dec 13, 2024
Merged

[chore] fix xconsumer mod versions #11884

merged 2 commits into from
Dec 13, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Dec 13, 2024

Description

make update-otel failed in contrib due to the new packages added in #11779. Pin a commit version for them in go mod to see if it unblocks contrib

@songy23 songy23 changed the title [chore] fix xreceiver and xconsumer mod versions [chore] fix xconsumer mod versions Dec 13, 2024
@songy23 songy23 added the release:blocker The issue must be resolved before cutting the next release label Dec 13, 2024
@dmitryax
Copy link
Member

Can you point to the failing make update-otel? contrib should not use the new unreleased module

@songy23
Copy link
Member Author

songy23 commented Dec 13, 2024

contrib doesn't use the new packages right now but needs to pull the new packages when running make update-otel, here's the output:

...
go: downloading go.opentelemetry.io/collector/consumer/consumererror v0.115.1-0.20241213185000-4593ba7de234
go: downloading go.opentelemetry.io/collector/pdata/pprofile v0.115.1-0.20241213185000-4593ba7de234
go: downloading go.opentelemetry.io/collector/consumer/xconsumer v0.115.0
go: downloading go.opentelemetry.io/collector/receiver/xreceiver v0.115.0
go: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/activedirectorydsreceiver tested by
	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/activedirectorydsreceiver.test imports
	go.opentelemetry.io/collector/consumer/consumertest imports
	go.opentelemetry.io/collector/consumer/xconsumer: reading go.opentelemetry.io/collector/consumer/xconsumer/go.mod at revision consumer/xconsumer/v0.115.0: unknown revision consumer/xconsumer/v0.115.0
go: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/activedirectorydsreceiver tested by
	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/activedirectorydsreceiver.test imports
	go.opentelemetry.io/collector/receiver/receivertest imports
	go.opentelemetry.io/collector/receiver/xreceiver: reading go.opentelemetry.io/collector/receiver/xreceiver/go.mod at revision receiver/xreceiver/v0.115.0: unknown revision receiver/xreceiver/v0.115.0
make[3]: *** [tidy] Error 1
make[2]: *** [receiver/activedirectorydsreceiver] Error 2
make[1]: *** [gotidy] Error 2
make: *** [update-otel] Error 2

@dmitryax
Copy link
Member

I see. Ok, I can do the same change as a follow-up to other deprecation

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (4593ba7) to head (380ac5b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11884   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         449      449           
  Lines       23761    23761           
=======================================
  Hits        21763    21763           
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added this pull request to the merge queue Dec 13, 2024
Merged via the queue into open-telemetry:main with commit 686132f Dec 13, 2024
59 of 68 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 13, 2024
@songy23 songy23 deleted the mod branch December 13, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants