-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[component] TelemetrySettings.MetricsLevel is experimental #9510
Comments
I expected TelemetrySettings to eventually include a |
I had assumed we would keep on using
But I am in favor of this regardless, I am just not sure where it should go ( |
Since we pass the |
I want to remove it, since it was used to configure "high cardinality" metrics in the past and we should have views and other configs for that. |
@codeboten Does the It would also be interesting to tie ignoring this level in components that use it today with the |
@codeboten Could you take a look at #9510 (comment) ? |
After discussing this at the 3-Apr-2024 SIG call, it was suggested that the use of a level is easier for users so we should keep it and remove the message about it being experimental. More advanced use-cases will be able to enable all metrics and use views for maximum flexibility/control over what metrics are emitted. |
I think we should distinguish
(2) could look something like: type LeveledMeterProvider interface {
MeterProvider(level configtelemetry.Level) metric.MeterProvider // noop/SDK provider depending on MetricsConfig.Level
} or be at a lower level (when getting the meter or the instrument). |
The
MetricsLevel
field is marked as experimental https://pkg.go.dev/go.opentelemetry.io/collector/component#TelemetrySettings. We should decide what to do with it (stabilize it, remove it, change it in some way)The text was updated successfully, but these errors were encountered: